Skip to content

Conversation

jimmyjames
Copy link
Contributor

@jimmyjames jimmyjames commented Oct 6, 2025

Description

What problem is being solved?

v0.8.0 of the spotless gradle plugin (used for linting) requires java 17. This library supports Java 11.

How is it being solved?

By telling dependabot to ignore versions >= 0.8.0

What changes are made to solve it?

Updating the dependabot file to add an ignore rule.

References

See failures in #222

https://github.com/diffplug/spotless/releases/tag/gradle%2F8.0.0

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated automated dependency-update settings to ignore updates for a specific Gradle plugin across the root project and selected example directories.
    • No changes to application behavior, features, or user experience.

@jimmyjames jimmyjames requested a review from a team as a code owner October 6, 2025 17:21
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Added ignore rules to .github/dependabot.yaml to skip updates for com.diffplug.spotless:spotless-plugin-gradle with constraint >=8.0.0 in three Gradle update entries: repository root, examples/basic-examples, and examples/opentelemetry.

Changes

Cohort / File(s) Summary
Dependabot config
.github/dependabot.yaml
Added ignore blocks for com.diffplug.spotless:spotless-plugin-gradle with constraint >=8.0.0 to the three Gradle update entries (root, examples/basic-examples, examples/opentelemetry); no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title succinctly captures the main change of adding an ignore rule for Spotless Gradle plugin versions v8.0.0 and above in the Dependabot configuration, and it uses the conventional “chore:” prefix to indicate a non-functional update. It precisely reflects the content of the changeset without extraneous detail, allowing reviewers to immediately grasp the purpose of the PR. The phrasing is clear, specific, and concise, focusing on the key version constraint being ignored.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/ignore-spotless-v8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.19%. Comparing base (5441476) to head (17135e5).

❌ Your project status has failed because the head coverage (35.19%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #227   +/-   ##
=========================================
  Coverage     35.19%   35.19%           
  Complexity     1071     1071           
=========================================
  Files           187      187           
  Lines          7087     7087           
  Branches        803      803           
=========================================
  Hits           2494     2494           
  Misses         4483     4483           
  Partials        110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5441476 and 17135e5.

📒 Files selected for processing (1)
  • .github/dependabot.yaml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test and Build OpenFGA (11)
  • GitHub Check: Test and Build OpenFGA (17)
  • GitHub Check: Test and Build OpenFGA (21)
  • GitHub Check: Analyze (java)

rhamzeh
rhamzeh previously approved these changes Oct 6, 2025
@jimmyjames
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@rhamzeh rhamzeh changed the title chore: ignore spotless v0.8.0 and greater versions chore: ignore spotless v8.0.0 and greater versions Oct 6, 2025
@jimmyjames jimmyjames added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit c79abb4 Oct 6, 2025
26 checks passed
@jimmyjames jimmyjames deleted the chore/ignore-spotless-v8 branch October 6, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants