Skip to content

chore(deps): upgrade dependencies #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+80 −80
Open

chore(deps): upgrade dependencies #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 77 additions & 77 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
},
"devDependencies": {
"@types/jest": "^29.5.14",
"@types/node": "^24.2.0",
"@types/node": "^24.2.1",
"@types/tiny-async-pool": "^2.0.3",
"@typescript-eslint/eslint-plugin": "^8.39.0",
"@typescript-eslint/parser": "^8.39.0",
"@typescript-eslint/eslint-plugin": "^8.39.1",
"@typescript-eslint/parser": "^8.39.1",
Comment on lines +34 to +35
Copy link

@coderabbitai coderabbitai bot Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Ensure CI/dev Node version satisfies @typescript-eslint v8 requirements.

@typescript-eslint v8 requires Node >= 18.18 in development environments. If your CI or local dev still uses Node 16 per the engines field, linting may fail.

Run this script to verify Node versions used in CI/dev and surface mismatches:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Package engines.node:"
jq -r '.engines.node // "N/A"' package.json

echo -e "\nDev deps of interest:"
jq -r '.devDependencies | {eslint, "@typescript-eslint/eslint-plugin", "@typescript-eslint/parser", "typescript", "@types/node"}' package.json

echo -e "\n.tsconfig files (if any):"
fd -a -H '^tsconfig.*\.json$' | while read -r f; do
  echo "==> $f"
  jq -r '{compilerOptions: .compilerOptions // {}}' "$f" | jq
done

echo -e "\n.nvmrc (if any):"
if [[ -f .nvmrc ]]; then cat .nvmrc; else echo "not found"; fi

echo -e "\nGitHub Actions node-version matrix (if any):"
fd -a -H '\.github/workflows/.*\.yml$' | while read -r wf; do
  echo "==> $wf"
  rg -n 'setup-node|node-version|matrix' -A2 -B2 "$wf" || true
done

Length of output: 1024

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Skip tsconfig parsing errors
echo "Package engines.node:"
jq -r '.engines.node // "N/A"' package.json || true

echo -e "\n.nvmrc (if any):"
if [[ -f .nvmrc ]]; then 
  cat .nvmrc
else 
  echo "not found"
fi

echo -e "\nGitHub Actions workflows Node versions:"
# List workflow files
fd .github/workflows -type f -name '*.yml' | while read -r wf; do
  echo "==> $wf"
  # Search for setup-node usage and node-version settings
  rg -n 'actions/setup-node' -A2 -B0 "$wf" && rg -n 'node-version' -A0 -B0 "$wf" || echo "  ⚠️ No setup-node or node-version found"
done

Length of output: 548

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Package engines.node:"
jq -r '.engines.node // "N/A"' package.json || true

echo -e "\n.nvmrc (if any):"
if [[ -f .nvmrc ]]; then
  cat .nvmrc
else
  echo "not found"
fi

echo -e "\nGitHub Actions workflows Node versions:"
# Use find instead of fd to locate workflow YAMLs
if [[ -d .github/workflows ]]; then
  find .github/workflows -type f -name '*.yml' | while read -r wf; do
    echo "==> $wf"
    # Look for setup-node usage and node-version keys
    grep -En 'actions/setup-node|node-version' "$wf" || echo "  ⚠️ No setup-node or node-version found"
  done
else
  echo "No .github/workflows directory found"
fi

Length of output: 670

Ensure CI and local Node ≥ 18.18 for @typescript-eslint v8

Your engines.node is currently set to >=16.15.0 (package.json) and there’s no .nvmrc or explicit Node version in CI (scorecard.yml). Since @typescript-eslint v8 requires Node ≥ 18.18, please:

• Update package.json

"engines": {
-   "node": ">=16.15.0"
+   "node": ">=18.18.0"
}

• Add or bump your .nvmrc to

18.18.0

• Pin Node in GitHub Actions (e.g. .github/workflows/scorecard.yml):

- uses: actions/setup-node@v3
  with:
-     node-version: 16
+     node-version: 18.18

This will ensure both your dev environment and CI satisfy @typescript-eslint v8’s minimum Node requirement.

🤖 Prompt for AI Agents 
In package.json around lines 34-35, engines.node is too low for
@typescript-eslint v8; update package.json's "engines.node" to ">=18.18.0", add
a .nvmrc file containing "18.18.0" at repository root, and pin CI to Node 18.18
by updating the GitHub Actions workflow (e.g., .github/workflows/scorecard.yml)
to use actions/setup-node@v3 with node-version set to "18.18".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply the suggestion from rabbitai? @rhamzeh updating node engine to 18?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

"eslint": "^8.57.1",
"jest": "^29.7.0",
"nock": "^14.0.9",
Expand Down