8237192: Generate stripped/public pdbs on Windows for jdk images

[sendaoYan]

Hi all,
This is backport JDK-8237192 from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.

File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it's necessary for jdk8u-dev.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8237192 needs maintainer approval

Issue

• JDK-8237192: Generate stripped/public pdbs on Windows for jdk images (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620
$ git checkout pull/620

Update a local copy of the PR:
$ git checkout pull/620
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 620

View PR using the GUI difftool:
$ git pr show -t 620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/620.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (c20969a6)
• 01: Full - Incremental (9400996c)
• 00: Full (cbe6bd05)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

keep it open

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk]

@sendaoYan This pull request is already open

[jerboaa]

This doesn't look like a backport of the patch it claims to be. I'd suggest to create a specific bug if you need a subset of a patch.

[sendaoYan]

This doesn't look like a backport of the patch it claims to be. I'd suggest to create a specific bug if you need a subset of a patch.

Okey, Thanks. I have create a new issue JDK-8353657 to record this test failure. I think this PR can be closed.

[sendaoYan]

This doesn't look like a backport of the patch it claims to be. I'd suggest to create a specific bug if you need a subset of a patch.

I have created a new PR to fix this issue.

#685