-
Notifications
You must be signed in to change notification settings - Fork 171
8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
ee072b3
to
50ad5e5
Compare
@jankratochvil Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Webrevs
|
…ytes for the "head" tag Reviewed-by: azvegint
50ad5e5
to
1fade41
Compare
The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1 |
It is needed in jdk8 as a prerequisite for JDK-6986863.
A testcase is included.
It is not a clean backport - source files are moved, include files angle vs. quote change, copyright years update.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/690/head:pull/690
$ git checkout pull/690
Update a local copy of the PR:
$ git checkout pull/690
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/690/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 690
View PR using the GUI difftool:
$ git pr show -t 690
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/690.diff
Using Webrev
Link to Webrev Comment