Skip to content

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Sep 6, 2025

It is needed in jdk8 as a prerequisite for JDK-6986863.
A testcase is included.
It is not a clean backport - source files are moved, include files angle vs. quote change, copyright years update.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8263622 needs maintainer approval

Issue

  • JDK-8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/690/head:pull/690
$ git checkout pull/690

Update a local copy of the PR:
$ git checkout pull/690
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/690/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 690

View PR using the GUI difftool:
$ git pr show -t 690

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/690.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 01ddf3d28004834d57f4cee92d0e055fb544a292 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag Sep 6, 2025
@openjdk
Copy link

openjdk bot commented Sep 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 6, 2025
@openjdk
Copy link

openjdk bot commented Sep 6, 2025

@jankratochvil Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@mlbridge
Copy link

mlbridge bot commented Sep 6, 2025

Webrevs

@jankratochvil jankratochvil marked this pull request as draft September 7, 2025 20:19
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2025
…ytes for the "head" tag

Reviewed-by: azvegint
@jankratochvil jankratochvil marked this pull request as ready for review September 8, 2025 14:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2025
@jankratochvil jankratochvil marked this pull request as draft September 8, 2025 14:20
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 8, 2025
@jankratochvil jankratochvil marked this pull request as ready for review September 9, 2025 08:05
@jankratochvil
Copy link
Author

The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant