Skip to content

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Sep 6, 2025

Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format and there are also other 2 minor conflicts.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #692 as a prerequisite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346465 needs maintainer approval
  • Change requires CSR request JDK-8367128 to be approved

Integration blocker

 ⚠️ Dependency #692 must be integrated first

Issues

  • JDK-8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles (Bug - P3)
  • JDK-8367128: Add a check in setData() to restrict the update of Built-In ICC_Profiles (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/693/head:pull/693
$ git checkout pull/693

Update a local copy of the PR:
$ git checkout pull/693
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/693/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 693

View PR using the GUI difftool:
$ git pr show -t 693

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/693.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/692 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3131dd1d5cb601b84cf898fff589596c2bcabdbc 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles Sep 6, 2025
@openjdk
Copy link

openjdk bot commented Sep 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 6, 2025
@openjdk
Copy link

openjdk bot commented Sep 6, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Sep 6, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2025

Webrevs

@jankratochvil jankratochvil marked this pull request as draft September 7, 2025 20:19
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2025
@jankratochvil jankratochvil force-pushed the 8263622-6986863-8347377-8346465 branch from 0487a20 to cd9bec7 Compare September 8, 2025 14:19
@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@jankratochvil this pull request can not be integrated into pr/692 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8263622-6986863-8347377-8346465
git fetch https://git.openjdk.org/jdk8u-dev.git pr/692
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/692"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 8, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Sep 8, 2025
…ICC_Profiles

Reviewed-by: aivanov, jdv, prr, serb
@jankratochvil jankratochvil force-pushed the 8263622-6986863-8347377-8346465 branch from cd9bec7 to d8ecef5 Compare September 9, 2025 08:09
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 9, 2025
@jankratochvil
Copy link
Author

The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1

@jankratochvil jankratochvil marked this pull request as ready for review September 9, 2025 11:18
@openjdk openjdk bot added rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant