-
Notifications
You must be signed in to change notification settings - Fork 171
8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/692
Are you sure you want to change the base?
8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles #693
Conversation
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
0487a20
to
cd9bec7
Compare
@jankratochvil this pull request can not be integrated into git checkout 8263622-6986863-8347377-8346465
git fetch https://git.openjdk.org/jdk8u-dev.git pr/692
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/692"
git push |
3076c4f
to
9bd2995
Compare
…ICC_Profiles Reviewed-by: aivanov, jdv, prr, serb
cd9bec7
to
d8ecef5
Compare
9bd2995
to
853ca11
Compare
The CI errors are false positives, they are the same as unpatched sources tested in: jankratochvil#1 |
Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format and there are also other 2 minor conflicts.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #692 as a prerequisite.
Progress
Integration blocker
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/693/head:pull/693
$ git checkout pull/693
Update a local copy of the PR:
$ git checkout pull/693
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/693/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 693
View PR using the GUI difftool:
$ git pr show -t 693
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/693.diff
Using Webrev
Link to Webrev Comment