Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 8, 2025

Hi all,

This pull request contains a backport of commit 37123ee7 from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Sergey Bylokhov on 27 Aug 2025 and had no reviewers.

The patch is clean(need to fix copyright and path to the test) and has been verified by the new test. No new issues were found by the jdk_desktop tests. The patch fixes the fullscreen windows, which are currently non-functional.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312518 needs maintainer approval

Issue

  • JDK-8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/694/head:pull/694
$ git checkout pull/694

Update a local copy of the PR:
$ git checkout pull/694
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 694

View PR using the GUI difftool:
$ git pr show -t 694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/694.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 37123ee7a5058ec81f2ef85a68fe9ae43b0ba216 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above Sep 8, 2025
@openjdk
Copy link

openjdk bot commented Sep 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 8, 2025
@mrserb mrserb marked this pull request as ready for review September 8, 2025 16:29
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant