Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented May 1, 2025

  • adds tab stops paragraph attributes to the RichTextArea
  • adds a ruler to the RichEditorDemoApp example

NOTE:
This PR requires changes in #1813 (JDK-8357393) to be integrated first.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356042: RichTextArea: tab stops attributes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1800/head:pull/1800
$ git checkout pull/1800

Update a local copy of the PR:
$ git checkout pull/1800
$ git pull https://git.openjdk.org/jfx.git pull/1800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1800

View PR using the GUI difftool:
$ git pr show -t 1800

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1800.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2025

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@andy-goryachev-oracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8356042.ruler
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jul 17, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jul 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2025

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants