8406: Chinese Rule strings are out of date

[youngledo]

Originally reported in adoptium/jmc-build#102 (comment).

The corresponding synchronization has been performed based on "https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention.

Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8406: Chinese Rule strings are out of date (Bug - P4)

Reviewers

• Alex Macdonald (@aptmac - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/662/head:pull/662
$ git checkout pull/662

Update a local copy of the PR:
$ git checkout pull/662
$ git pull https://git.openjdk.org/jmc.git pull/662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 662

View PR using the GUI difftool:
$ git pr show -t 662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/662.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @youngledo, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user youngledo" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@youngledo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8406: Chinese Rule strings are out of date

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 22e4459: 8400: Add more show options for JMX Console graphs
• 06297dc: 8421: Missing Eclipse classpath entry defaults
• c8e8a13: 8416: Better Eclipse classpath entry defaults
• ... and 3 more: https://git.openjdk.org/jmc/compare/dd6fd901e3ee4fdd766a2b4dfe43bcc1388fbf2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[aptmac]

@youngledo Thanks for the PR! Just a couple of housekeeping items:

• I had opened a ticket for this issue (https://bugs.openjdk.org/browse/JMC-8406), if you could change the title of this PR to "8406: Chinese Rule strings are out of date" it will satisfy one of the jcheck requirements

• Contributing to JMC requires completion of the Oracle Contributor Agreement, please follow the instructions listed in this automatic comment from the openjdk bot: 8406: Chinese Rule strings are out of date #662 (comment)

[youngledo]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 01: Full - Incremental (71b64ad4)
• 00: Full (b47a912c)

[bridgekeeper]

@youngledo This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[youngledo]

Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks!

[aptmac]

Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks!

Sorry for the delay here, I was out of office for a bit. The PR looks good to me, and it's nice to see that the OCA went through.

I forgot to mention previously, but if you could enable the GitHub actions on your fork then the testing workflow should run on this PR. See: https://wiki.openjdk.org/display/SKARA/Testing#Testing-Configuringworkflowstorun

[aptmac]

Thanks for running the CI, it looks like there are some formatting failures at the moment.

These failures are old, and were fixed in: 87860ce

If you rebase ontop of current HEAD then those errors should go away.