adding mesh tally amalgamation algorithm #3553
Open
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix constructor issue * not avoiding code repetation * addressing suggestion from @gonuke * addresing suggestions * fix cluster_element_integer_index_ name * better variable name * better variable name * fix get bin from elem method * api change * API change * allow mesh amalgamation with/without AMR
magnoxemo
force-pushed
the
mesh_tally_amalgamation
branch
from
56c91ab to
fb663fd
Compare
|
primary result from Cardinal side: We will cluster elements together for tallying if the previous OpenMC solution has
OpenMC run 1: 
amlgamating elements for tallying together: 
OpenMC solution after mesh tally amalgamation: 
I think it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the mesh tally amalgamation algorithm.
If the user wants to do mesh tally amalgamation from cardinal side they will set the
_amalgamation = true. Then It will create a hash map of elements point to the first element of the cluster. If any element isn't part of a cluster it will point to itself.If a reaction happens in any of the element of a cluster, when OpenMC quires the libMesh mesh for tallying it will send the bin we have at the first element in that cluster(using the hash map) . From cardinal side then, the tally score from the first element will be pulled and stored in the all elements in the cluster.
closes #3552
Checklist
more about this is here PR