Skip to content

Conversation

kb019
Copy link
Contributor

@kb019 kb019 commented Dec 20, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Currently, while using the infinite hook, the number of results fetched per page is 50, which is the default value. I was just thinking, what if we wanted to fetch only 20 results per page or any number other than 50? I think it would be nice to have an option to configure that in the useOpenMrsInfinite hook. I have made the necessary changes accordingly.Thanks

Copy link

@IamLRBA IamLRBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. To align with OpenMRS development practices, please I would like to consider the following:

  • JIRA Ticket: Create and reference a JIRA ticket for this feature to facilitate tracking and documentation. Pull Request Tips

  • Detailed Description: Update the pull request description to include the purpose of the change, implementation details, and any relevant information to aid the review process.

  • Mark Ready for Review: Once you've completed the implementation and testing, please mark this pull request as "Ready for Review" to initiate the formal review process.

  • Ensure Tests Pass: Run all tests locally to confirm that the changes do not introduce any regressions. If you encounter test failures, provide details so we can assist in resolving them.

Your attention to these points will help streamline the review and integration process. Thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants