-
Notifications
You must be signed in to change notification settings - Fork 263
feat: Add smooth height resizing to Implementer Tools popup #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@denniskigen What do you think about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @yugalkaushik , Thanks for your effort, I just have few suggestions.
packages/apps/esm-implementer-tools-app/src/popup/popup.component.tsx
Outdated
Show resolved
Hide resolved
packages/apps/esm-implementer-tools-app/src/popup/popup.component.tsx
Outdated
Show resolved
Hide resolved
Hi @yugalkaushik , thanks for this. Please implement the resizing of the internal parts of the popup. We can't merge this PR without that, since it would introduce buggy behavior. You can just add additional commits to this branch; no need to rebase or anything, since the commits will be squashed at merge time. The E2E test failure looks unrelated to this branch, please ignore it for now. For some reason I can't see the re-run button, but we'll see what happens when you push your updates. If the problem persists we can look into it then. As an aside, this is not required of you or anything, but if you can figure out an easy way to take short screencast videos, that would be a great way to demonstrate this feature. Even just a 10s video of you resizing the thing, scrolling the main window and the popup separately, clicking a thing or two. Like your screenshots, but animated. |
implementer-tools.mp4 |
@brandones While working on this component, I realized that custom resizing can be a bit tricky and causes UI glitches. Therefore, I propose a better approach: using a two-state popup that can be toggled by a button. implementer-tools.new.mp4 |
While smooth resizing would be slick, I think the "maximize" button is a fine approach. Thanks @yugalkaushik . A CSS transition to make it look smooth would be great, also. |
Should I complete it or this feature is included in GSOC project. |
I don't know of any GSOC project containing this feature, perhaps @jayasanka-sack can let us know if there is one. If you are available to complete this feature, it would be greatly appreciated! |
Hi @brandones, yes there's a GSoC project related to implementer tools: https://openmrs.atlassian.net/wiki/spaces/projects/pages/393248769/Improved+Implementer+Tools+GSoC+2025 That said, no worries at all; @yugalkaushik you’ve already done some awesome work here, and I’d definitely encourage you to keep going with it! |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR adds a smooth height resizing functionality to the DevTools popup component. Users can now resize the popup by dragging the top edge, with the minimum height constraint set to the default value (50vh).
Changes
Testing
Screenshots
Before:
After:
Other
Next, I will work on resizing the internal components to ensure they adapt dynamically within the resized popup.