-
Notifications
You must be signed in to change notification settings - Fork 261
(feat)O3-4671: Adding config to enable implementors add version number. #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
version: '3.0.0', | ||
showVersion: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how the others feel but we could default this to false so that it doesn't affect other implementers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True i thought I had set it to false, my bad.
}, | ||
showVersion: { | ||
_type: Type.Boolean, | ||
_default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this to false since the default value for version
is null
@suubi-joshua Thank you so much for your work on this PR. Could you kindly fix the merge conflicts, please? |
Hi @denniskigen @ibacher do u have any thoughts on this addition. The background is that we wanted a way to show the version number of the release to end users mostly for error reporting investing issues such as cache. This PR adds a simple optional config to indicate the version number as per this slack thread https://openmrs.slack.com/archives/CKS32D55G/p1745848235764369 |
If we're going to support a version number, it should be a build-time constant, not set via config. Otherwise, I think the approach is fine. |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
I have added a configuration to enable implementers add the version number of the distribution. This is beneficial for some implementers to debug when in the field.
Screenshots
Screencast from 02-06-25 11:24:07.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-4671
Other