-
Notifications
You must be signed in to change notification settings - Fork 277
(feat) Migrate to using RSpack everywhere #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ibacher
wants to merge
2
commits into
main
Choose a base branch
from
feat/rspack-for-everything
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Size Change: -4.9 MB (-44.01%) 🎉 Total Size: 6.24 MB
ℹ️ View Unchanged
|
Member
|
Should this use the default Rspack config instead? |
denniskigen
approved these changes
Jul 9, 2025
Member
denniskigen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've posed a couple of questions.
denniskigen
approved these changes
Jul 10, 2025
Member
|
Set to draft because the e2e test failures are owing to changes in this diff. |
aecd923 to
78d7818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This is basically a follow-on to #1346 with the following changes:
This PR does have things that are technically breaking changes, but all related to removing functionality that was not widely used, specifically:
debugcommand is removed from the CLI. Please use eitheropenmrs developorwebpack/rspack serveScreenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-5206
Other
The app shell currently uses RSpack's
ModuleFederationPluginV1rather than the 1.5 used elsewhere as that doesn't work without other changes I haven't yet figured out. Hopefully that will be ironed out soon.