-
Couldn't load subscription status.
- Fork 1.1k
[Explore vis] update time range when brush on the chart #10606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explore vis] update time range when brush on the chart #10606
Conversation
update line, area and bar to support update time range from chart Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10606 +/- ##
==========================================
- Coverage 60.25% 60.24% -0.01%
==========================================
Files 4450 4451 +1
Lines 119043 119085 +42
Branches 19613 19631 +18
==========================================
+ Hits 71727 71744 +17
- Misses 42350 42368 +18
- Partials 4966 4973 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yulong Ruan <[email protected]>
| from: moment(timeRange.from).toISOString(), | ||
| to: moment(timeRange.to).toISOString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we need to check whether timeRange from and to is valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time range picker should be able to gracefully handle invalid value, it set the time range to default last 15 minutes.
src/plugins/explore/public/components/visualizations/utils/time_range_brush.ts
Show resolved
Hide resolved
Signed-off-by: Yulong Ruan <[email protected]>
Description
Add time zoom in to line/bar/area which x-axis is time
Screen.Recording.2025-09-30.at.15.00.54.mov
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration