Skip to content

Conversation

@ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 30, 2025

Description

Add time zoom in to line/bar/area which x-axis is time

Screen.Recording.2025-09-30.at.15.00.54.mov

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: add time zoom in interaction to explore vis

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

update line, area and bar to support update time range from chart

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl ruanyl changed the title [Explore vis] add zoom in interaction to explore vis [Explore vis] add time zoom in interaction to explore vis Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.24%. Comparing base (ff7ebc8) to head (fb5577d).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...lic/components/visualizations/bar/to_expression.ts 0.00% 0 Missing and 6 partials ⚠️
...components/visualizations/visualization_render.tsx 53.84% 6 Missing ⚠️
...ponents/visualizations/visualization_container.tsx 37.50% 5 Missing ⚠️
...s/vis_type_vega/public/vega_view/vega_base_view.js 0.00% 4 Missing ⚠️
...s/explore/public/embeddable/explore_embeddable.tsx 33.33% 2 Missing ⚠️
...public/embeddable/explore_embeddable_component.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10606      +/-   ##
==========================================
- Coverage   60.25%   60.24%   -0.01%     
==========================================
  Files        4450     4451       +1     
  Lines      119043   119085      +42     
  Branches    19613    19631      +18     
==========================================
+ Hits        71727    71744      +17     
- Misses      42350    42368      +18     
- Partials     4966     4973       +7     
Flag Coverage Δ
Linux_1 26.59% <0.00%> (-0.01%) ⬇️
Linux_2 38.82% <ø> (ø)
Linux_3 38.79% <ø> (ø)
Linux_4 32.86% <54.54%> (+<0.01%) ⬆️
Windows_1 26.61% <0.00%> (-0.01%) ⬇️
Windows_2 38.80% <ø> (ø)
Windows_3 38.79% <ø> (-0.01%) ⬇️
Windows_4 32.86% <54.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wanglam
wanglam previously approved these changes Oct 13, 2025
Signed-off-by: Yulong Ruan <[email protected]>
Hailong-am
Hailong-am previously approved these changes Oct 13, 2025
Comment on lines +74 to +75
from: moment(timeRange.from).toISOString(),
to: moment(timeRange.to).toISOString(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we need to check whether timeRange from and to is valid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time range picker should be able to gracefully handle invalid value, it set the time range to default last 15 minutes.

@ruanyl ruanyl changed the title [Explore vis] add time zoom in interaction to explore vis [Explore vis] update time range when brush on the chart Oct 14, 2025
@ruanyl ruanyl merged commit 4628b06 into opensearch-project:main Oct 14, 2025
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants