[Feature] Handle source as both string and json object #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyCaroline17
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
LilyCaroline17
force-pushed
the
handleQueryString
branch
3 times, most recently
from
f6102cd to
8cd6daa
Compare
LilyCaroline17
changed the title
LilyCaroline17
force-pushed
the
handleQueryString
branch
from
8cd6daa to
c8b31bf
Compare
Signed-off-by: Emily Guo <[email protected]>
LilyCaroline17
force-pushed
the
handleQueryString
branch
from
c8b31bf to
079fa04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to API changes of storage of queries in local index, to properly display queries in the dashboard, queries are handled as both string and json objects and modified accordingly. There should be no issues with backporting, as we can handle what source has been stored as, as well as when it's stored as string.
Issues Resolved
Related to opensearch-project/query-insights#424
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Both cases below will display the same source query to the user.
Case 1: Source is an object
Case 2: Source is a string