fix: add explicit mapping for cancelled status #2291

ab-ghosh · 2025-10-14T11:15:46Z

Add case for 'cancelled' conclusion in GitLab provider CreateStatus
Map 'cancelled' to 'canceled' for GitLab API compatibility
Add unit test to verify cancelled status handling

📝 Description of the Change

👨🏻‍ Linked Jira

https://issues.redhat.com/browse/SRVKP-9050

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

- Add case for 'cancelled' conclusion in GitLab provider CreateStatus - Map 'cancelled' to 'canceled' for GitLab API compatibility - Set descriptive title 'cancelled validating this commit' - Ensures proper status reporting when PipelineRuns are cancelled via PR close

gemini-code-assist · 2025-10-14T11:16:00Z

Summary of Changes

Hello @ab-ghosh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the GitLab provider did not correctly interpret the 'cancelled' status. It introduces a specific case to map 'cancelled' to 'canceled' for GitLab API compatibility and sets an appropriate status title. A corresponding unit test has been added to ensure the new handling works as expected.

Highlights

GitLab Status Handling: Added explicit handling for the 'cancelled' status within the GitLab provider's CreateStatus function.
API Compatibility: Mapped the 'cancelled' conclusion to 'canceled' to ensure proper compatibility with the GitLab API.
Unit Testing: Included a new unit test to verify that the 'cancelled' status is correctly processed and mapped.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2025-10-14T11:16:30Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

b8d6415 fix(gitlab): add explicit mapping for cancelled status

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request correctly adds support for the 'cancelled' status in the GitLab provider by mapping it to 'canceled' for API compatibility, and includes a unit test to verify the new logic. The implementation is sound. I have one suggestion to refactor the code slightly by combining similar cases, which would improve code clarity and maintainability.

gemini-code-assist · 2025-10-14T11:17:17Z

pkg/provider/gitlab/gitlab.go

 	case "neutral":
 		statusOpts.Conclusion = "canceled"
 		statusOpts.Title = "stopped"
+	case "cancelled":
+		statusOpts.Conclusion = "canceled"
+		statusOpts.Title = "cancelled validating this commit"


The logic for neutral and cancelled conclusions is very similar. You can combine these cases to reduce code duplication and improve maintainability.

Suggested change

case "neutral":

statusOpts.Conclusion = "canceled"

statusOpts.Title = "stopped"

case "cancelled":

statusOpts.Conclusion = "canceled"

statusOpts.Title = "cancelled validating this commit"

case "neutral", "cancelled":

if statusOpts.Conclusion == "neutral" {

statusOpts.Title = "stopped"

} else {

statusOpts.Title = "cancelled validating this commit"

}

statusOpts.Conclusion = "canceled"

i'd rather duplication than code spagetthi, so you can discard this

chmouel · 2025-10-14T11:21:19Z

can we fix canceled across the codebase ?

ab-ghosh · 2025-10-14T11:36:53Z

I've reviewed the codebase and didn't find any other inconsistencies related to the use of “canceled” for GitLab.

zakisk · 2025-10-14T11:53:36Z

can we fix canceled across the codebase ?

@chmouel what do you mean by fixing? removing?

theakshaypant

Feel free to resolve the comment if it is incorrect, added the comment more for learning for myself.

pkg/provider/gitlab/gitlab_test.go

pipelines-as-code bot added fix gitlab testing labels Oct 14, 2025

gemini-code-assist bot reviewed Oct 14, 2025

View reviewed changes

theakshaypant reviewed Oct 14, 2025

View reviewed changes

pkg/provider/gitlab/gitlab_test.go Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add explicit mapping for cancelled status #2291

fix: add explicit mapping for cancelled status #2291

Uh oh!

ab-ghosh commented Oct 14, 2025

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Uh oh!

pipelines-as-code bot commented Oct 14, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 14, 2025

Uh oh!

chmouel Oct 14, 2025

Uh oh!

chmouel commented Oct 14, 2025

Uh oh!

ab-ghosh commented Oct 14, 2025

Uh oh!

zakisk commented Oct 14, 2025

Uh oh!

theakshaypant left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

fix: add explicit mapping for cancelled status #2291

Are you sure you want to change the base?

fix: add explicit mapping for cancelled status #2291

Uh oh!

Conversation

ab-ghosh commented Oct 14, 2025

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Oct 14, 2025

🔍 PR Lint Feedback

⚠️ Items that need attention:

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

chmouel Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

chmouel commented Oct 14, 2025

Uh oh!

ab-ghosh commented Oct 14, 2025

Uh oh!

zakisk commented Oct 14, 2025

Uh oh!

theakshaypant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants