Skip to content

Adding test cases for "Add support for event-ttl in Kube API Server Operator" #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adding test cases for "Add support for event-ttl in Kube API Server Operator" #1941

wants to merge 1 commit into from

Conversation

gangwgr
Copy link

@gangwgr gangwgr commented Oct 16, 2025 •
edited
Loading

Adding test cases for "Add support for event-ttl in Kube API Server Operator"

Assisted-by: Claude AI
test run

./cluster-kube-apiserver-operator-tests-ext run-test "[Jira:kube-apiserver][sig-api-machinery][FeatureGate:EventTTL] Event TTL Configuration should configure and validate eventTTLMinutes=5m [Serial][Disruptive][Slow][Suite:openshift/cluster-kube-apiserver-operator/conformance/serial]"
  Running Suite:  - /Users/rgangwar/Downloads/backupoffice/cluster-kube-apiserver-operator
  ========================================================================================
  Random Seed: 1760683956 - will randomize all specs

  Will run 1 of 1 specs
  ------------------------------
  [Jira:kube-apiserver][sig-api-machinery][FeatureGate:EventTTL] Event TTL Configuration should configure and validate eventTTLMinutes=5m [Disruptive][Slow][Suite:openshift/cluster-kube-apiserver-operator/conformance/serial]
  github.com/openshift/cluster-kube-apiserver-operator/test/extended/event_ttl.go:53
Found configuration for host https://xxxxxxxxxxxxxxx.
    STEP: === Starting test for eventTTLMinutes=5 at 2025-10-17T12:22:36+05:30 === @ 10/17/25 12:22:36.853
    STEP: Step 1: Checking if EventTTL feature gate is present @ 10/17/25 12:22:36.853
    STEP:   Current FeatureSet: TechPreviewNoUpgrade @ 10/17/25 12:22:37.976
    STEP: [OK] EventTTL feature gate found and is already enabled @ 10/17/25 12:22:37.976
    STEP: 
    Step 2: Configuring eventTTLMinutes=5 in KubeAPIServer CR @ 10/17/25 12:22:37.976
    STEP:   Patch data: {"spec":{"eventTTLMinutes":5}} @ 10/17/25 12:22:37.976
    STEP: [OK] eventTTLMinutes=5 configured at 2025-10-17T12:22:38+05:30 @ 10/17/25 12:22:38.534
    STEP: Step 3: Waiting for new revision to roll out (timeout: 20 minutes)... @ 10/17/25 12:22:38.534
    STEP:   Rollout started at: 2025-10-17T12:22:38+05:30 @ 10/17/25 12:22:38.534
    STEP:   Initial state: 3 pods, oldest created at 2025-10-17T11:24:09+05:30, initial revision: 11 @ 10/17/25 12:22:39
    STEP:   [Attempt 1] All 3 pods are running. New pods: 0/0. Revision: 11 @ 10/17/25 12:22:54.447
    STEP:   [Attempt 4] All 3 pods are running. New pods: 0/0. Revision: 11 @ 10/17/25 12:23:52.5
    STEP:   [Attempt 8] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": dial tcp: lookup xxxxxxxxxxxxxxx: i/o timeout - error from a previous attempt: http2: client connection lost @ 10/17/25 12:25:36.037
    STEP:   [Attempt 9] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": dial tcp: lookup xxxxxxxxxxxxxxx: i/o timeout @ 10/17/25 12:26:06.039
    STEP:   [Attempt 10] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:26:44.198
    STEP:   [Attempt 11] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:26:54.284
    STEP:   [Attempt 12] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:27:04.637
    STEP:   [Attempt 13] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:27:33.575
    STEP:   [Attempt 14] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:27:45.257
    STEP:   [Attempt 15] Error listing pods: Get "https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue": net/http: TLS handshake timeout @ 10/17/25 12:27:55.604
    STEP:   [Attempt 16] All 3 pods are running. New pods: 1/1. Revision: 12 @ 10/17/25 12:27:57.595
    STEP:   [Attempt 20] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:28:54.617
    STEP:   [Attempt 24] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:29:54.655
    STEP:   [Attempt 28] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:30:54.555
    STEP: [OK] New revision rolled out successfully in 8m30.982850458s @ 10/17/25 12:31:09.516
    STEP:   Configuration took: 8m31.541280917s total @ 10/17/25 12:31:09.516
    STEP: Step 4: Verifying event-ttl=5m in kube-apiserver config @ 10/17/25 12:31:09.516
    STEP: Checking event-ttl in pod config file @ 10/17/25 12:31:09.516
    STEP:   Checking config file in pod: kube-apiserver-ci-ln-7vzxymt-72292-z8z4t-master-0 @ 10/17/25 12:31:10.141
    STEP:   [OK] Found event-ttl=5m in config.yaml @ 10/17/25 12:31:10.536
    STEP: [OK] eventTTLMinutes=5 verified in config file @ 10/17/25 12:31:10.536
    STEP: 
    Step 5: Validating that events actually expire after 5 minutes @ 10/17/25 12:31:10.536
    STEP:   Waiting 30 seconds for new TTL configuration to fully propagate... @ 10/17/25 12:31:10.536
    STEP: Creating test namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.537
    STEP: [OK] Test namespace created: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.897
    STEP: Creating NEW test event: apiload-event-1760684500 in namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.897
    STEP:   (This event should expire after the configured TTL, not the default 3h) @ 10/17/25 12:31:40.897
    STEP:   Event creation time: 2025-10-17T12:31:40+05:30 @ 10/17/25 12:31:40.897
    STEP: [OK] Event created at: 2025-10-17T12:31:41+05:30 @ 10/17/25 12:31:41.251
    STEP: [OK] Event confirmed to exist (UID: 285cf1d4-80d8-4ea4-bde3-614e7d13e93f) @ 10/17/25 12:31:41.598
    STEP:   Event CreationTimestamp: 2025-10-17T12:31:41+05:30 @ 10/17/25 12:31:41.598
    STEP:   This NEW event should expire after 5m (not the default 3h) @ 10/17/25 12:31:41.598
    STEP: Waiting 8 minutes for event to expire (expected expiration: 2025-10-17T12:39:41+05:30)... @ 10/17/25 12:31:41.598
    STEP:   ... 1/8 minutes elapsed @ 10/17/25 12:32:41.6
    STEP:   ... 2/8 minutes elapsed @ 10/17/25 12:33:41.599
    STEP:   ... 3/8 minutes elapsed @ 10/17/25 12:34:41.599
    STEP:   ... 4/8 minutes elapsed @ 10/17/25 12:35:41.598
    STEP:   ... 5/8 minutes elapsed @ 10/17/25 12:36:41.599
    STEP:   ... 6/8 minutes elapsed @ 10/17/25 12:37:41.6
    STEP:   ... 7/8 minutes elapsed @ 10/17/25 12:38:41.608
    STEP:   ... 8/8 minutes elapsed @ 10/17/25 12:39:41.608
    STEP: [OK] Event expired and deleted after approximately 8m0s @ 10/17/25 12:39:47.062
    STEP:   Expected TTL: 5m, Actual TTL: 8m0s @ 10/17/25 12:39:47.062
    STEP: 
    [SUCCESS] All steps completed successfully for eventTTLMinutes=5 @ 10/17/25 12:39:47.062
    STEP:   Total test duration: 17m10.20367875s @ 10/17/25 12:39:47.062
    STEP: Cleaning up test namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:39:47.062
    STEP: 
    Cleaning up eventTTLMinutes=5 configuration @ 10/17/25 12:39:47.722
    STEP:   [OK] eventTTLMinutes configuration removed @ 10/17/25 12:39:48.19
    STEP:   Waiting for kube-apiserver rollout after cleanup... @ 10/17/25 12:39:48.191
    STEP:   Initial state: 3 pods, oldest created at 2025-10-17T12:25:21+05:30, initial revision: 12 @ 10/17/25 12:39:48.663
    STEP:   [Attempt 1] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:40:04.151
    STEP:   [Attempt 4] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:40:49.265
    STEP:   [Attempt 8] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:41:49.201
    STEP:   [Attempt 12] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:42:49.227
    STEP:   [Attempt 16] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:43:49.236
    STEP:   [Attempt 20] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:44:49.128
    STEP:   [Attempt 23] 2/3 pods running. Not running: [kube-apiserver-ci-ln-7vzxymt-72292-z8z4t-master-1 (Pending)]. New pods: 1/2 running @ 10/17/25 12:45:34.148
    STEP:   [Attempt 24] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:45:49.637
    STEP:   [Attempt 28] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:46:51.06
    STEP:   [Attempt 32] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:47:49.082
    STEP:   [OK] Kube-apiserver rollout completed after cleanup @ 10/17/25 12:48:34.166
  • [1557.313 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 1557.315 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[Jira:kube-apiserver][sig-api-machinery][FeatureGate:EventTTL] Event TTL Configuration should configure and validate eventTTLMinutes=5m [Serial][Disruptive][Slow][Suite:openshift/cluster-kube-apiserver-operator/conformance/serial]",
    "lifecycle": "blocking",
    "duration": 1557319,
    "startTime": "2025-10-17 06:52:36.847517 UTC",
    "endTime": "2025-10-17 07:18:34.167477 UTC",
    "result": "passed",
    "output": "  STEP: === Starting test for eventTTLMinutes=5 at 2025-10-17T12:22:36+05:30 === @ 10/17/25 12:22:36.853\n  STEP: Step 1: Checking if EventTTL feature gate is present @ 10/17/25 12:22:36.853\n  STEP:   Current FeatureSet: TechPreviewNoUpgrade @ 10/17/25 12:22:37.976\n  STEP: [OK] EventTTL feature gate found and is already enabled @ 10/17/25 12:22:37.976\n  STEP: \n  Step 2: Configuring eventTTLMinutes=5 in KubeAPIServer CR @ 10/17/25 12:22:37.976\n  STEP:   Patch data: {\"spec\":{\"eventTTLMinutes\":5}} @ 10/17/25 12:22:37.976\n  STEP: [OK] eventTTLMinutes=5 configured at 2025-10-17T12:22:38+05:30 @ 10/17/25 12:22:38.534\n  STEP: Step 3: Waiting for new revision to roll out (timeout: 20 minutes)... @ 10/17/25 12:22:38.534\n  STEP:   Rollout started at: 2025-10-17T12:22:38+05:30 @ 10/17/25 12:22:38.534\n  STEP:   Initial state: 3 pods, oldest created at 2025-10-17T11:24:09+05:30, initial revision: 11 @ 10/17/25 12:22:39\n  STEP:   [Attempt 1] All 3 pods are running. New pods: 0/0. Revision: 11 @ 10/17/25 12:22:54.447\n  STEP:   [Attempt 4] All 3 pods are running. New pods: 0/0. Revision: 11 @ 10/17/25 12:23:52.5\n  STEP:   [Attempt 8] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": dial tcp: lookup xxxxxxxxxxxxxxx: i/o timeout - error from a previous attempt: http2: client connection lost @ 10/17/25 12:25:36.037\n  STEP:   [Attempt 9] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": dial tcp: lookup xxxxxxxxxxxxxxx: i/o timeout @ 10/17/25 12:26:06.039\n  STEP:   [Attempt 10] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:26:44.198\n  STEP:   [Attempt 11] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:26:54.284\n  STEP:   [Attempt 12] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:27:04.637\n  STEP:   [Attempt 13] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:27:33.575\n  STEP:   [Attempt 14] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:27:45.257\n  STEP:   [Attempt 15] Error listing pods: Get \"https://xxxxxxxxxxxxxxx/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=app%3Dopenshift-kube-apiserver%2Capiserver%3Dtrue\": net/http: TLS handshake timeout @ 10/17/25 12:27:55.604\n  STEP:   [Attempt 16] All 3 pods are running. New pods: 1/1. Revision: 12 @ 10/17/25 12:27:57.595\n  STEP:   [Attempt 20] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:28:54.617\n  STEP:   [Attempt 24] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:29:54.655\n  STEP:   [Attempt 28] All 3 pods are running. New pods: 2/2. Revision: 12 @ 10/17/25 12:30:54.555\n  STEP: [OK] New revision rolled out successfully in 8m30.982850458s @ 10/17/25 12:31:09.516\n  STEP:   Configuration took: 8m31.541280917s total @ 10/17/25 12:31:09.516\n  STEP: Step 4: Verifying event-ttl=5m in kube-apiserver config @ 10/17/25 12:31:09.516\n  STEP: Checking event-ttl in pod config file @ 10/17/25 12:31:09.516\n  STEP:   Checking config file in pod: kube-apiserver-ci-ln-7vzxymt-72292-z8z4t-master-0 @ 10/17/25 12:31:10.141\n  STEP:   [OK] Found event-ttl=5m in config.yaml @ 10/17/25 12:31:10.536\n  STEP: [OK] eventTTLMinutes=5 verified in config file @ 10/17/25 12:31:10.536\n  STEP: \n  Step 5: Validating that events actually expire after 5 minutes @ 10/17/25 12:31:10.536\n  STEP:   Waiting 30 seconds for new TTL configuration to fully propagate... @ 10/17/25 12:31:10.536\n  STEP: Creating test namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.537\n  STEP: [OK] Test namespace created: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.897\n  STEP: Creating NEW test event: apiload-event-1760684500 in namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:31:40.897\n  STEP:   (This event should expire after the configured TTL, not the default 3h) @ 10/17/25 12:31:40.897\n  STEP:   Event creation time: 2025-10-17T12:31:40+05:30 @ 10/17/25 12:31:40.897\n  STEP: [OK] Event created at: 2025-10-17T12:31:41+05:30 @ 10/17/25 12:31:41.251\n  STEP: [OK] Event confirmed to exist (UID: 285cf1d4-80d8-4ea4-bde3-614e7d13e93f) @ 10/17/25 12:31:41.598\n  STEP:   Event CreationTimestamp: 2025-10-17T12:31:41+05:30 @ 10/17/25 12:31:41.598\n  STEP:   This NEW event should expire after 5m (not the default 3h) @ 10/17/25 12:31:41.598\n  STEP: Waiting 8 minutes for event to expire (expected expiration: 2025-10-17T12:39:41+05:30)... @ 10/17/25 12:31:41.598\n  STEP:   ... 1/8 minutes elapsed @ 10/17/25 12:32:41.6\n  STEP:   ... 2/8 minutes elapsed @ 10/17/25 12:33:41.599\n  STEP:   ... 3/8 minutes elapsed @ 10/17/25 12:34:41.599\n  STEP:   ... 4/8 minutes elapsed @ 10/17/25 12:35:41.598\n  STEP:   ... 5/8 minutes elapsed @ 10/17/25 12:36:41.599\n  STEP:   ... 6/8 minutes elapsed @ 10/17/25 12:37:41.6\n  STEP:   ... 7/8 minutes elapsed @ 10/17/25 12:38:41.608\n  STEP:   ... 8/8 minutes elapsed @ 10/17/25 12:39:41.608\n  STEP: [OK] Event expired and deleted after approximately 8m0s @ 10/17/25 12:39:47.062\n  STEP:   Expected TTL: 5m, Actual TTL: 8m0s @ 10/17/25 12:39:47.062\n  STEP: \n  [SUCCESS] All steps completed successfully for eventTTLMinutes=5 @ 10/17/25 12:39:47.062\n  STEP:   Total test duration: 17m10.20367875s @ 10/17/25 12:39:47.062\n  STEP: Cleaning up test namespace: event-ttl-test-5m-1760684500 @ 10/17/25 12:39:47.062\n  STEP: \n  Cleaning up eventTTLMinutes=5 configuration @ 10/17/25 12:39:47.722\n  STEP:   [OK] eventTTLMinutes configuration removed @ 10/17/25 12:39:48.19\n  STEP:   Waiting for kube-apiserver rollout after cleanup... @ 10/17/25 12:39:48.191\n  STEP:   Initial state: 3 pods, oldest created at 2025-10-17T12:25:21+05:30, initial revision: 12 @ 10/17/25 12:39:48.663\n  STEP:   [Attempt 1] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:40:04.151\n  STEP:   [Attempt 4] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:40:49.265\n  STEP:   [Attempt 8] All 3 pods are running. New pods: 0/0. Revision: 12 @ 10/17/25 12:41:49.201\n  STEP:   [Attempt 12] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:42:49.227\n  STEP:   [Attempt 16] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:43:49.236\n  STEP:   [Attempt 20] All 3 pods are running. New pods: 1/1. Revision: 13 @ 10/17/25 12:44:49.128\n  STEP:   [Attempt 23] 2/3 pods running. Not running: [kube-apiserver-ci-ln-7vzxymt-72292-z8z4t-master-1 (Pending)]. New pods: 1/2 running @ 10/17/25 12:45:34.148\n  STEP:   [Attempt 24] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:45:49.637\n  STEP:   [Attempt 28] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:46:51.06\n  STEP:   [Attempt 32] All 3 pods are running. New pods: 2/2. Revision: 13 @ 10/17/25 12:47:49.082\n  STEP:   [OK] Kube-apiserver rollout completed after cleanup @ 10/17/25 12:48:34.166\n"
  }
]%

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr
Once this PR has been reviewed and has the lgtm label, please assign vrutkovs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gangwgr

This comment was marked as duplicate.

Sign in to view

gangwgr

This comment was marked as duplicate.

Sign in to view

gangwgr

This comment was marked as duplicate.

Sign in to view

gangwgr

This comment was marked as duplicate.

Sign in to view

gangwgr
gangwgr commented Oct 16, 2025
View reviewed changes
Copy link
Author

@gangwgr gangwgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Code review complete. Found 13 suggestion(s).

@gangwgr gangwgr force-pushed the event-ttl-tests branch 5 times, most recently from 52b8f7e to a5e1528 Compare October 17, 2025 07:28
@gangwgr gangwgr changed the title Pre-merge testing Adding test cases for "Add support for event-ttl in Kube API Server Operator" Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gangwgr