[WIP]: OCPBUGS-39241: Rate-limit RequiredInstallerResourcesMissing events in InstallerController to prevent SNO upgrade test failures

[ShazaAldawamneh]

rate-limit RequiredInstallerResourcesMissing events in InstallerController

During SNO upgrades, the installer would emit a flood of
RequiredInstallerResourcesMissing events for transient missing secrets
and configmaps, causing the [bz-etcd] pathological test to fail.

This patch adds a 30-second rate-limit per unique set of missing resources:

• Events for the same missing set are only emitted once per 30 seconds.
• Aggregated errors are still returned to trigger retries.
• Uses InstallerController.now() for testable timestamps.
• lastMissingEvent map tracks last emission times per missing resource set.

This prevents event spam while preserving retry logic and ensures
transient missing resources are still detected correctly.

[openshift-ci-robot]

@ShazaAldawamneh: This pull request references Jira Issue OCPBUGS-39241, which is invalid:

• expected the bug to target the "4.18.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-39241 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

rate-limit RequiredInstallerResourcesMissing events in InstallerController

During SNO upgrades, the installer would emit a flood of
RequiredInstallerResourcesMissing events for transient missing secrets
and configmaps, causing the [bz-etcd] pathological test to fail.

This patch adds a 30-second rate-limit per unique set of missing resources:

• Events for the same missing set are only emitted once per 30 seconds.
• Aggregated errors are still returned to trigger retries.
• Uses InstallerController.now() for testable timestamps.
• lastMissingEvent map tracks last emission times per missing resource set.

This prevents event spam while preserving retry logic and ensures
transient missing resources are still detected correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShazaAldawamneh
Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ShazaAldawamneh]

/retest-required

[openshift-ci]

@ShazaAldawamneh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator	386f5a6	link	true	/test e2e-gcp-operator
ci/prow/okd-scos-e2e-aws-ovn	386f5a6	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial	386f5a6	link	true	/test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.