OCPBUGS-60077: Silence ovnkube-lib.sh to avoid mass of logs to collectors

[michaelalang]

silenced default output of ovnkube-lib.sh and made it ENV dependning instead

on ~12 days running pods the amount of logs procuded is fairly high

$ oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node 
NAME                 READY   STATUS    RESTARTS      AGE
ovnkube-node-464zd   8/8     Running   8             12d
ovnkube-node-9rrtb   8/8     Running   8             12d
...
$ oc -n openshift-ovn-kubernetes logs $(oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node -oname | head -1) ovn-acl-logging | wc -l
431762

unfortunately those logs are not helpful as they are bash's Print a trace of simple commands output only.
With cloning the set -x behavior form ovnkube.sh the PR makes the output ENV controll able reducing logs in the default setup.

[openshift-ci]

Hi @michaelalang. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@michaelalang: This pull request references Jira Issue OCPBUGS-60077, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

silenced default output of ovnkube-lib.sh and made it ENV dependning instead

on ~12 days running pods the amount of logs procuded is fairly high

$ oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node 
NAME                 READY   STATUS    RESTARTS      AGE
ovnkube-node-464zd   8/8     Running   8             12d
ovnkube-node-9rrtb   8/8     Running   8             12d
...
$ oc -n openshift-ovn-kubernetes logs $(oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node -oname | head -1) ovn-acl-logging | wc -l
431762

unfortunately those logs are not helpful as they are bash's Print a trace of simple commands output only.
With cloning the set -x behavior form ovnkube.sh the PR makes the output ENV controll able reducing logs in the default setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kyrtapz]

silenced default output of ovnkube-lib.sh and made it ENV dependning instead

on ~12 days running pods the amount of logs procuded is fairly high

$ oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node 
NAME                 READY   STATUS    RESTARTS      AGE
ovnkube-node-464zd   8/8     Running   8             12d
ovnkube-node-9rrtb   8/8     Running   8             12d
...
$ oc -n openshift-ovn-kubernetes logs $(oc -n openshift-ovn-kubernetes get po -l app=ovnkube-node -oname | head -1) ovn-acl-logging | wc -l
431762

unfortunately those logs are not helpful as they are bash's Print a trace of simple commands output only. With cloning the set -x behavior form ovnkube.sh the PR makes the output ENV controll able reducing logs in the default setup.

This is not a problem for containers other than ovn-acl-logging which runs the script in a loop.
Other containers only print some lines at the start before starting the main executable.
Please limit the changes to start-audit-log-rotation()

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelalang
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michaelalang]

This is not a problem for containers other than ovn-acl-logging which runs the script in a loop. Other containers only print some lines at the start before starting the main executable. Please limit the changes to start-audit-log-rotation()

@kyrtapz done and thanks for the hint on being able to limit only the particular function <3

[kyrtapz]

/ok-to-test

[openshift-ci]

@michaelalang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade	d69bd30	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/security	d69bd30	link	false	/test security
ci/prow/e2e-aws-ovn-serial	d69bd30	link	false	/test e2e-aws-ovn-serial
ci/prow/e2e-ovn-step-registry	d69bd30	link	false	/test e2e-ovn-step-registry
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade	d69bd30	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	d69bd30	link	true	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-vsphere-ovn-dualstack	d69bd30	link	false	/test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-hypershift-ovn-kubevirt	d69bd30	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-gcp-ovn-upgrade	d69bd30	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	d69bd30	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-aws-ovn-hypershift-conformance	d69bd30	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade	d69bd30	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn	d69bd30	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-upgrade	d69bd30	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-ovn-hybrid-step-registry	d69bd30	link	false	/test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration	d69bd30	link	false	/test e2e-aws-ovn-local-to-shared-gateway-mode-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.