HIVE-2954: resolve nil pointer exception when deleting a privatelink cluster with preserve on delete.

[jstuever]

privatelink: pass privatelink enabled status into actuators

Previously, the aws hub actuator was using its own platform logic to
determine if privatelink was enabled on the cluster deployment. This
caused a nil pointer exception when deleting non-aws clusters with
preserve on delete because the spec.platform.aws value was nil. More
importantly, the logic was flawed because it should instead be based on
the cluster deployment's platform.

This change passes the privatelink enabled status from the controller to
each of the actuators on creation. The controller was already using the
cluster deploymnet's platform to determine if privatelink is enabled.
Passing this value into the actuators enables the aws hub actuator to
properly determine if cleanup is required while avoiding the nil pointer
exception altogether.

privatelink: reconcile to exit early when privatelink is not enabled.

Previously, the privatelink controller would create actuators for every
clusterdeployment regardless of if it uses privatelink. This caused
serveral issues in clusers that were not configured for the specified
hub and/or link platforms.

This change causes the reconcile to exit early when the cd does not have
privatelink enabled and has never been configured to use privatelink as
evident by the lack of a finalizer. This keeps the cluster from trying
to create actuators when privatelink is disabled while still enabling
to cleanup in the case where it had previously been enabled.

[openshift-ci-robot]

@jstuever: This pull request references HIVE-2954 which is a valid jira issue.

In response to this:

privatelink: pass privatelink enabled status into actuators

Previously, the aws hub actuator was using its own platform logic to
determine if privatelink was enabled on the cluster deployment. This
caused a nil pointer exception when deleting non-aws clusters with
preserve on delete because the spec.platform.aws value was nil. More
importantly, the logic was flawed because it should instead be based on
the cluster deployment's platform.

This change passes the privatelink enabled status from the controller to
each of the actuators on creation. The controller was already using the
cluster deploymnet's platform to determine if privatelink is enabled.
Passing this value into the actuators enables the aws hub actuator to
properly determine if cleanup is required while avoiding the nil pointer
exception altogether.

privatelink: reconcile to exit early when privatelink is not enabled.

Previously, the privatelink controller would create actuators for every
clusterdeployment regardless of if it uses privatelink. This caused
serveral issues in clusers that were not configured for the specified
hub and/or link platforms.

This change causes the reconcile to exit early when the cd does not have
privatelink enabled and has never been configured to use privatelink as
evident by the lack of a finalizer. This keeps the cluster from trying
to create actuators when privatelink is disabled while still enabling
to cleanup in the case where it had previously been enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.33%. Comparing base (c279504) to head (d1e41de).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
...g/controller/privatelink/privatelink_controller.go	0.00%	11 Missing ⚠️
...rivatelink/actuator/gcpactuator/gcplinkactuator.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
- Coverage   50.33%   50.33%   -0.01%     
==========================================
  Files         284      284              
  Lines       33952    33968      +16     
==========================================
+ Hits        17090    17098       +8     
- Misses      15517    15523       +6     
- Partials     1345     1347       +2     

Files with missing lines	Coverage Δ
...privatelink/actuator/awsactuator/awshubactuator.go	88.85% <100.00%> (+0.02%)	⬆️
...rivatelink/actuator/gcpactuator/gcplinkactuator.go	85.20% <50.00%> (-0.22%)	⬇️
...g/controller/privatelink/privatelink_controller.go	10.09% <0.00%> (-0.29%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2uasimojo]

This lgtm, but I would at least like to see some extra comments as noted inline... or we could do some refactoring 😇

[2uasimojo]

Suggested change

	// process. We can use the finazer itself to determine if we can safely return here. If there
	// process. We can use the finalizer itself to determine if we can safely return here. If there

[jstuever]

Done

[2uasimojo]

lgtm -- wanna fix the typo?

[2uasimojo]

/test e2e-gcp

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.