Skip to content

OCPBUGS-60583: Unblock cluster installation when dependent systemd unit fails #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chizhang21
Copy link

Background

When the network is unstable, the dependent systemd unit required by the installation service(apply-host-config and start-cluster-installation) may fail to start. If this happens, these two services will not run, causing the cluster installation process to be blocked.

What has been changed

  • Improved the dependency configuration and failure handling between the dependent systemd unit and the installation service.
  • Ensured that temporary failures in the dependent unit do not permanently block the installation flow.

How to test

  1. Simulate an unstable network environment (such as by introducing packet loss or toggling the network interface).
  2. Start the cluster installation process.
  3. Confirm that even if the dependent systemd unit fails initially, the installation service is eventually executed and the installation is not blocked.

Please let me know if further documentation or tests are needed.

In unstable network conditions, the dependent systemd unit required by the apply-host-config/start-cluster-installation service may fail to start.
This can prevent the installation process from proceeding.
This commit improves the dependency handling so that temporary failures in the dependent unit no longer permanently block the cluster installation.

Signed-off-by: cz21 <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2025
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

Hi @chizhang21. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chizhang21 chizhang21 changed the title fix: unblock cluster installation when dependent systemd unit fails OCPBUGS-60583: Unblock cluster installation when dependent systemd unit fails Aug 19, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2025
@openshift-ci-robot
Copy link
Contributor

@chizhang21: This pull request references Jira Issue OCPBUGS-60583, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Background

When the network is unstable, the dependent systemd unit required by the installation service(apply-host-config and start-cluster-installation) may fail to start. If this happens, these two services will not run, causing the cluster installation process to be blocked.

What has been changed

  • Improved the dependency configuration and failure handling between the dependent systemd unit and the installation service.
  • Ensured that temporary failures in the dependent unit do not permanently block the installation flow.

How to test

  1. Simulate an unstable network environment (such as by introducing packet loss or toggling the network interface).
  2. Start the cluster installation process.
  3. Confirm that even if the dependent systemd unit fails initially, the installation service is eventually executed and the installation is not blocked.

Please let me know if further documentation or tests are needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants