Skip to content

AGENT-1269: Update references to agent-installer-ui image #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

AGENT-1269: Update references to agent-installer-ui image #9868

wants to merge 3 commits into from

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Aug 5, 2025

After the agent-installer-ui image is built downstream, we can update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI bits can also be removed.

rwsu added 3 commits July 11, 2025 15:42
@rwsu
AGENT-1205: Extract agent-tui during boot for interactive workflow
4879a6e 
Created agent-extract-tui.service for the interactive-disconnected
workflow to extract the agent-tui and nmstate libraries during boot.

The files are extracted from the agent-install-utils image. In the
interactive-disconnected workflow, the image is available on the
local container storage. They need to be extracted before the
agent-interactive-console.service starts.
@rwsu
Extract libnmstate.so to /usr/local/lib
fa9ff85
@rwsu
AGENT-1269: Update references to agent-installer-ui image
ce8b8e6 
After the agent-installer-ui image is built downstream, we can
update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI
bits can also be removed.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2025 •
edited by openshift-ci bot
Loading

@rwsu: This pull request references AGENT-1269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

After the agent-installer-ui image is built downstream, we can update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI bits can also be removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-tests ce8b8e6 link true /test integration-tests
ci/prow/e2e-agent-compact-ipv4-none-platform ce8b8e6 link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/okd-scos-e2e-aws-ovn ce8b8e6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-multi-network-techpreview ce8b8e6 link false /test e2e-vsphere-ovn-multi-network-techpreview
ci/prow/e2e-vsphere-host-groups-ovn-techpreview ce8b8e6 link false /test e2e-vsphere-host-groups-ovn-techpreview
ci/prow/e2e-azure-ovn-resourcegroup ce8b8e6 link false /test e2e-azure-ovn-resourcegroup

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 6, 2025

/hold

Until the image is included in the release.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwsu @openshift-ci-robot