OCPBUGS-60288: check ipv6 dns during bootkube #9876
Conversation
The dig command only returns results for A records by default. For single-stack ipv6, we need to also check for AAAA records so as not to block bootkube.
openshift-ci-robot
added
jira/severity-critical
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-60288, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ? |
|
@patrickdillon: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@iurygregory: This pull request references Jira Issue OCPBUGS-60288, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-60288, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -10,7 +10,8 @@ function lookup_url() { | |||
| unset IPS | |||
There was a problem hiding this comment.
I don't think this is a bug (yet), but I'd sure feel more comfortable if this said local instead of unset.
| @@ -10,7 +10,8 @@ function lookup_url() { | |||
| unset IPS | |||
| unset IP | |||
There was a problem hiding this comment.
IP isn't even used in this function any more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
This whole lookup_url function (which looks up a domain name, not a URL) could be replaced with nslookup, which does both A and AAAA lookups by default, prints some helpful debugging information, and returns an error code indicating whether the domain resolved successfully or not:
$ nslookup www.google.com; echo "Result: $?"
Server: 127.0.0.53
Address: 127.0.0.53#53
Non-authoritative answer:
Name: www.google.com
Address: 142.250.66.196
Name: www.google.com
Address: 2404:6800:4006:811::2004
Result: 0
$
$ nslookup wvw.google.com; echo "Result: $?"
Server: 127.0.0.53
Address: 127.0.0.53#53
** server can't find wvw.google.com: NXDOMAIN
Result: 1
The dig command only returns results for A records by default. For single-stack ipv6, we need to also check for AAAA records so
as not to block bootkubeso we don't send false negative warnings that we can't resolve DNS when we actually can.Should cut down on this warning in bootkube: