Skip to content

CNTRLPLANE-1258: set up openshift-tests-extension and add a sanity test #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

CNTRLPLANE-1258: set up openshift-tests-extension and add a sanity test #536

merged 2 commits into from
Aug 18, 2025

Conversation

wangke19
Copy link
Contributor

@wangke19 wangke19 commented Aug 15, 2025 •
edited by coderabbitai bot
Loading

Description

This commit introduces a binary and supporting structure to enable the
execution of OpenShift origin (openshift-apiserver) tests using the Open Test Environment (OTE).

It lays the groundwork for moving origin test in openshift/origin to
be executed from this repository using OTE.

Checklist from https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0

  • Revise project with Dockerfile for CI
  • Initialize the extension
  • Build the binary (make build)

$ make tests-ext-build
GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all CGO_ENABLED=0
go build -o openshift-apiserver-tests-ext -ldflags "-X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.CommitFromGit=1d7faa585' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.BuildDate=2025-08-18T07:17:09Z' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.GitTreeState=clean'" ./cmd/openshift-apiserver-tests-ext

the extension is to be registered here openshift/origin#30120

  • Test locally (following bellow)
    Local Tests
  • Confirm info outputs correct API version, metadata
$ ./openshift-apiserver-tests-ext info
{
    "apiVersion": "v1.1",
    "source": {
        "commit": "1d7faa585",
        "build_date": "2025-08-18T07:17:09Z",
        "git_tree_state": "clean"
    },
    "component": {
        "product": "openshift",
        "type": "payload",
        "name": "openshift-apiserver"
    },
    "suites": [
        {
            "name": "openshift/openshift-apiserver/conformance/parallel",
            "description": "",
            "parents": [
                "openshift/conformance/parallel"
            ],
            "qualifiers": [
                "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (!(name.contains(\"[Serial]\") || name.contains(\"[Slow]\")))"
            ]
        },
        {
            "name": "openshift/openshift-apiserver/conformance/serial",
            "description": "",
            "parents": [
                "openshift/conformance/serial"
            ],
            "qualifiers": [
                "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Serial]\"))"
            ]
        },
        {
            "name": "openshift/openshift-apiserver/optional/slow",
            "description": "",
            "parents": [
                "openshift/optional/slow"
            ],
            "qualifiers": [
                "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Slow]\"))"
            ]
        },
        {
            "name": "openshift/openshift-apiserver/all",
            "description": "",
            "qualifiers": [
                "source == \"openshift:payload:openshift-apiserver\""
            ]
        }
    ],
    "images": null
}
  • Confirm list outputs tests properly filtered by environment
$ ./openshift-apiserver-tests-ext list
[
  {
    "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
    "labels": {},
    "resources": {
      "isolation": {}
    },
    "source": "openshift:payload:openshift-apiserver",
    "codeLocations": [
      "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:8",
      "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9"
    ],
    "lifecycle": "blocking",
    "environmentSelector": {}
  }
]
  • Confirm we can run tests locally and produces valid JSONL test results:
$ ./openshift-apiserver-tests-ext run-test -n "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]"
  Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
  ======================================================================
  Random Seed: 1755501604 - will randomize all specs

  Will run 1 of 1 specs
  ------------------------------
  [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
  /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
  • [0.000 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 0.001 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
    "lifecycle": "blocking",
    "duration": 0,
    "startTime": "2025-08-18 07:20:04.695966 UTC",
    "endTime": "2025-08-18 07:20:04.696962 UTC",
    "result": "passed",
    "output": ""
  }
]
  • Confirm we can run suites locally.
$  ./openshift-apiserver-tests-ext run-suite openshift/openshift-apiserver/all
  Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
  ======================================================================
  Random Seed: 1755501656 - will randomize all specs

  Will run 1 of 1 specs
  ------------------------------
  [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
  /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
  • [0.000 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 0.000 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
    "lifecycle": "blocking",
    "duration": 0,
    "startTime": "2025-08-18 07:20:56.289052 UTC",
    "endTime": "2025-08-18 07:20:56.289702 UTC",
    "result": "passed",
    "output": ""
  }
]

Blocks

Summary by CodeRabbit

  • New Features

    • Introduces an OpenShift API Server tests extension CLI, registering conformance, serial, slow, and all-inclusive suites.
    • Ships the extension binary in container images (compressed) for easier distribution.

  • Tests

    • Adds a sanity test and a test payload entry for the OpenShift API Server suite.

  • Build

    • New make targets to build and run/update the tests extension; embeds version metadata.

  • Chores

    • Expands .gitignore.
    • Updates and vendors testing dependencies (Ginkgo/Gomega and related libraries).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sanchezl August 15, 2025 13:49
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@wangke19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1d7faa5 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19 wangke19 changed the title [WIP]CNTRLPLANE-1258: set up openshift-tests-extension and add a sanity test CNTRLPLANE-1258: set up openshift-tests-extension and add a sanity test Aug 15, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Add openshift-tests-extension scaffolding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Add openshift-tests-extension scaffolding, background: https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Description

This commit introduces a binary and supporting structure to enable the
execution of OpenShift origin (openshift-apiserver) tests using the Open Test Environment (OTE).

It lays the groundwork for moving origin test in openshift/origin to
be executed from this repository using OTE.

Checklist from https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0

  • Revise project with Dockerfile for CI
  • Initialize the extension
  • Build the binary (make build)

$ make tests-ext-build
GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all CGO_ENABLED=0
go build -o openshift-apiserver-tests-ext -ldflags "-X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.CommitFromGit=1d7faa585' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.BuildDate=2025-08-18T07:17:09Z' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.GitTreeState=clean'" ./cmd/openshift-apiserver-tests-ext

the extension is to be registered here openshift/origin#30120

  • Test locally (following bellow)
    Local Tests
  • Confirm info outputs correct API version, metadata
$ ./openshift-apiserver-tests-ext info
{
   "apiVersion": "v1.1",
   "source": {
       "commit": "1d7faa585",
       "build_date": "2025-08-18T07:17:09Z",
       "git_tree_state": "clean"
   },
   "component": {
       "product": "openshift",
       "type": "payload",
       "name": "openshift-apiserver"
   },
   "suites": [
       {
           "name": "openshift/openshift-apiserver/conformance/parallel",
           "description": "",
           "parents": [
               "openshift/conformance/parallel"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (!(name.contains(\"[Serial]\") || name.contains(\"[Slow]\")))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/conformance/serial",
           "description": "",
           "parents": [
               "openshift/conformance/serial"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Serial]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/optional/slow",
           "description": "",
           "parents": [
               "openshift/optional/slow"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Slow]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/all",
           "description": "",
           "qualifiers": [
               "source == \"openshift:payload:openshift-apiserver\""
           ]
       }
   ],
   "images": null
}
  • Confirm list outputs tests properly filtered by environment
$ ./openshift-apiserver-tests-ext list
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "labels": {},
   "resources": {
     "isolation": {}
   },
   "source": "openshift:payload:openshift-apiserver",
   "codeLocations": [
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:8",
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9"
   ],
   "lifecycle": "blocking",
   "environmentSelector": {}
 }
]
  • Confirm we can run tests locally and produces valid JSONL test results:
$ ./openshift-apiserver-tests-ext run-test -n "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]"
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501604 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.001 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:04.695966 UTC",
   "endTime": "2025-08-18 07:20:04.696962 UTC",
   "result": "passed",
   "output": ""
 }
]
  • Confirm we can run suites locally.
$  ./openshift-apiserver-tests-ext run-suite openshift/openshift-apiserver/all
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501656 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.000 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:56.289052 UTC",
   "endTime": "2025-08-18 07:20:56.289702 UTC",
   "result": "passed",
   "output": ""
 }
]

Blocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Description

This commit introduces a binary and supporting structure to enable the
execution of OpenShift origin (openshift-apiserver) tests using the Open Test Environment (OTE).

It lays the groundwork for moving origin test in openshift/origin to
be executed from this repository using OTE.

Checklist from https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0

  • Revise project with Dockerfile for CI
  • Initialize the extension
  • Build the binary (make build)

$ make tests-ext-build
GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all CGO_ENABLED=0
go build -o openshift-apiserver-tests-ext -ldflags "-X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.CommitFromGit=1d7faa585' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.BuildDate=2025-08-18T07:17:09Z' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.GitTreeState=clean'" ./cmd/openshift-apiserver-tests-ext

the extension is to be registered here openshift/origin#30120

  • Test locally (following bellow)
    Local Tests
  • Confirm info outputs correct API version, metadata
$ ./openshift-apiserver-tests-ext info
{
   "apiVersion": "v1.1",
   "source": {
       "commit": "1d7faa585",
       "build_date": "2025-08-18T07:17:09Z",
       "git_tree_state": "clean"
   },
   "component": {
       "product": "openshift",
       "type": "payload",
       "name": "openshift-apiserver"
   },
   "suites": [
       {
           "name": "openshift/openshift-apiserver/conformance/parallel",
           "description": "",
           "parents": [
               "openshift/conformance/parallel"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (!(name.contains(\"[Serial]\") || name.contains(\"[Slow]\")))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/conformance/serial",
           "description": "",
           "parents": [
               "openshift/conformance/serial"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Serial]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/optional/slow",
           "description": "",
           "parents": [
               "openshift/optional/slow"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Slow]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/all",
           "description": "",
           "qualifiers": [
               "source == \"openshift:payload:openshift-apiserver\""
           ]
       }
   ],
   "images": null
}
  • Confirm list outputs tests properly filtered by environment
$ ./openshift-apiserver-tests-ext list
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "labels": {},
   "resources": {
     "isolation": {}
   },
   "source": "openshift:payload:openshift-apiserver",
   "codeLocations": [
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:8",
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9"
   ],
   "lifecycle": "blocking",
   "environmentSelector": {}
 }
]
  • Confirm we can run tests locally and produces valid JSONL test results:
$ ./openshift-apiserver-tests-ext run-test -n "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]"
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501604 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.001 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:04.695966 UTC",
   "endTime": "2025-08-18 07:20:04.696962 UTC",
   "result": "passed",
   "output": ""
 }
]
  • Confirm we can run suites locally.
$  ./openshift-apiserver-tests-ext run-suite openshift/openshift-apiserver/all
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501656 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.000 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:56.289052 UTC",
   "endTime": "2025-08-18 07:20:56.289702 UTC",
   "result": "passed",
   "output": ""
 }
]

Blocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025 •
edited by openshift-ci bot
Loading

@wangke19: This pull request references CNTRLPLANE-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Description

This commit introduces a binary and supporting structure to enable the
execution of OpenShift origin (openshift-apiserver) tests using the Open Test Environment (OTE).

It lays the groundwork for moving origin test in openshift/origin to
be executed from this repository using OTE.

Checklist from https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0

  • Revise project with Dockerfile for CI
  • Initialize the extension
  • Build the binary (make build)

$ make tests-ext-build
GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all CGO_ENABLED=0
go build -o openshift-apiserver-tests-ext -ldflags "-X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.CommitFromGit=1d7faa585' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.BuildDate=2025-08-18T07:17:09Z' -X 'github.com/openshift-eng/openshift-tests-extension/pkg/version.GitTreeState=clean'" ./cmd/openshift-apiserver-tests-ext

the extension is to be registered here openshift/origin#30120

  • Test locally (following bellow)
    Local Tests
  • Confirm info outputs correct API version, metadata
$ ./openshift-apiserver-tests-ext info
{
   "apiVersion": "v1.1",
   "source": {
       "commit": "1d7faa585",
       "build_date": "2025-08-18T07:17:09Z",
       "git_tree_state": "clean"
   },
   "component": {
       "product": "openshift",
       "type": "payload",
       "name": "openshift-apiserver"
   },
   "suites": [
       {
           "name": "openshift/openshift-apiserver/conformance/parallel",
           "description": "",
           "parents": [
               "openshift/conformance/parallel"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (!(name.contains(\"[Serial]\") || name.contains(\"[Slow]\")))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/conformance/serial",
           "description": "",
           "parents": [
               "openshift/conformance/serial"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Serial]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/optional/slow",
           "description": "",
           "parents": [
               "openshift/optional/slow"
           ],
           "qualifiers": [
               "(source == \"openshift:payload:openshift-apiserver\") \u0026\u0026 (name.contains(\"[Slow]\"))"
           ]
       },
       {
           "name": "openshift/openshift-apiserver/all",
           "description": "",
           "qualifiers": [
               "source == \"openshift:payload:openshift-apiserver\""
           ]
       }
   ],
   "images": null
}
  • Confirm list outputs tests properly filtered by environment
$ ./openshift-apiserver-tests-ext list
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "labels": {},
   "resources": {
     "isolation": {}
   },
   "source": "openshift:payload:openshift-apiserver",
   "codeLocations": [
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:8",
     "/home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9"
   ],
   "lifecycle": "blocking",
   "environmentSelector": {}
 }
]
  • Confirm we can run tests locally and produces valid JSONL test results:
$ ./openshift-apiserver-tests-ext run-test -n "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]"
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501604 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.001 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:04.695966 UTC",
   "endTime": "2025-08-18 07:20:04.696962 UTC",
   "result": "passed",
   "output": ""
 }
]
  • Confirm we can run suites locally.
$  ./openshift-apiserver-tests-ext run-suite openshift/openshift-apiserver/all
 Running Suite:  - /home/kewang/github-go/openshift/openshift-apiserver
 ======================================================================
 Random Seed: 1755501656 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]
 /home/kewang/github-go/openshift/openshift-apiserver/test/extended/main.go:9
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.000 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[Jira:openshift-apiserver][sig-api-machinery] sanity test should always pass [Suite:openshift/openshift-apiserver/conformance/parallel]",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-08-18 07:20:56.289052 UTC",
   "endTime": "2025-08-18 07:20:56.289702 UTC",
   "result": "passed",
   "output": ""
 }
]

Blocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 mentioned this pull request Aug 18, 2025
Open
vrutkovs
vrutkovs approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@tkashem
Copy link
Contributor

tkashem commented Aug 18, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkashem, vrutkovs, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6930049 into openshift:main Aug 18, 2025
11 of 12 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-apiserver
This PR has been included in build ose-openshift-apiserver-container-v4.20.0-202508182255.p0.g6930049.assembly.stream.el9.
All builds following this will include this PR.

@wangke19 wangke19 deleted the test-extd branch August 19, 2025 01:51
@wangke19
Copy link
Contributor Author

@coderabbitai generate sequence diagram

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

Unable to generate sequence diagram: No PR summary found. Please run a review first.

@wangke19
Copy link
Contributor Author

@coderabbitai review skip vendor

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

@wangke19 I'll review the changes while skipping vendor files as requested.

✏️ Learnings added 
Learnt from: wangke19
URL: https://github.com/openshift/openshift-apiserver/pull/536

Timestamp: 2025-08-25T08:50:45.524Z
Learning: Skip vendor files during code reviews as they contain third-party dependencies that don't require detailed analysis.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Adds an OpenShift API Server tests extension: new CLI entrypoint, build/update targets, Docker image packaging, and a minimal sanity test with payload metadata. Expands go.mod with Ginkgo v2, Gomega, and an OpenShift tests extension, vendoring Ginkgo and Slim Sprig. Minor repo ignore update.

Changes

Cohort / File(s) Summary
Repo config
/.gitignore		 Ignore /openshift-apiserver-tests-ext.
Build system
/Makefile, /images/Dockerfile.rhel		 New tests extension build/update targets with metadata ldflags; Dockerfile builds and gzips openshift-apiserver-tests-ext and includes it in final image. Update/verify scripts extended for generated code.
Extension CLI
/cmd/openshift-apiserver-tests-ext/main.go		 New Go CLI wiring an OpenShift API Server tests extension into the registry, registering suites, normalizing labels, attaching specs, and executing a Cobra command.
Tests and payloads
/test/extended/main.go, /test/.openshift-tests-extension/openshift_payload_openshift-apiserver.json		 Adds an always-pass Ginkgo sanity test and a tests-extension payload JSON for the OpenShift apiserver suite.
Module/dependencies
/go.mod		 Adds Ginkgo v2, Gomega, openshift-tests-extension; updates x/*, pprof; replaces Ginkgo with OpenShift fork; adds indirect Slim Sprig.
Vendor: Slim Sprig v3
/vendor/github.com/go-task/slim-sprig/v3/*		 Vendored lightweight Sprig fork: string/date/json/dict/list/regex/url utilities and docs/config files.
Vendor: Ginkgo v2 (core, CLI, internals, tools)
/vendor/github.com/onsi/ginkgo/v2/...		 Vendored Ginkgo v2: DSL/core runtime, reporters/formatters, CLI commands (run/build/watch/generate/labels/outline/unfocus), parallel support (HTTP/RPC), watch/delta, output interception, progress reporting, suite/spec/node execution machinery, utilities, and documentation.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant B as openshift-apiserver-tests-ext (CLI)
  participant R as Registry
  participant E as Extension (openshift:payload:openshift-apiserver)
  participant S as Suites/Specs

  U->>B: Execute CLI (e.g., run/update)
  B->>R: Create registry
  B->>E: Initialize extension (domain/payload/name)
  E->>E: Register suites and hooks
  E->>S: Build specs from Ginkgo suite
  B->>B: Execute command (Cobra)
  alt Run flow
    B->>S: Run selected specs
  else Update flow
    B->>B: Update payload files
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60–90 minutes

Poem

A bunny compiled a shiny new test,
With Ginkgo it hopped, through suites it pressed.
It zipped a tool, Docker gave it a nest,
Labels aligned, conformance addressed—
Now payloads sing, “all checks impressed!” 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sanchezl sanchezl Awaiting requested review from sanchezl

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangke19 @openshift-ci-robot @tkashem @openshift-bot @vrutkovs