Skip to content

Conversation

Thealisyed
Copy link

@Thealisyed Thealisyed commented Oct 15, 2025

Replacement command used:
go mod edit --replace=github.com/openshift/library-go=github.com/openshift-cherrypick-robot/library-go@cd876ac95495b21b4443029b187dec745aed3fa2

go mod tidy

@openshift-ci openshift-ci bot requested review from dgrisonnet and sanchezl October 15, 2025 10:20
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Thealisyed
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

coderabbitai bot commented Oct 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…space in spec.path

openshift/library-go#2012 was already merged
hence we ran the following commands for this PR:
go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c
go mod tidy
@Thealisyed Thealisyed changed the title Temp:Replace library-go with cherrypick for for testing OCPBUGS-61662 [release-4.19] OCPBUGS-61662: Add API validation to reject # or whitespace in spec.path Oct 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 15, 2025
@openshift-ci-robot
Copy link

@Thealisyed: This pull request references Jira Issue OCPBUGS-61662, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-47773 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-47773 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replacement command used:
go mod edit --replace=github.com/openshift/library-go=github.com/openshift-cherrypick-robot/library-go@cd876ac95495b21b4443029b187dec745aed3fa2

go mod tidy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Thealisyed
Copy link
Author

Have pinged to get ART bump PR merged in order to help pass the verify job [it bumps the rhel-9-release-golang-1.22-openshift-4.18]

Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@Thealisyed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 626019d link true /test okd-scos-images
ci/prow/e2e-aws-ovn-serial-2of2 626019d link true /test e2e-aws-ovn-serial-2of2
ci/prow/unit 626019d link true /test unit
ci/prow/verify 626019d link true /test verify
ci/prow/e2e-aws-ovn-upgrade 626019d link true /test e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 626019d link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn 626019d link true /test e2e-aws-ovn
ci/prow/verify-deps 626019d link true /test verify-deps
ci/prow/e2e-aws-ovn-serial-1of2 626019d link true /test e2e-aws-ovn-serial-1of2
ci/prow/images 626019d link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants