-
Notifications
You must be signed in to change notification settings - Fork 103
[release-4.19] OCPBUGS-61662: Add API validation to reject # or whitespace in spec.path #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Thealisyed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…space in spec.path openshift/library-go#2012 was already merged hence we ran the following commands for this PR: go get github.com/openshift/library-go@2dd58ebcfe22424a4e7ae919ab61e62a0d03632c go mod tidy
939e412
to
626019d
Compare
@Thealisyed: This pull request references Jira Issue OCPBUGS-61662, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Have pinged to get ART bump PR merged in order to help pass the verify job [it bumps the |
@Thealisyed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Replacement command used:
go mod edit --replace=github.com/openshift/library-go=github.com/openshift-cherrypick-robot/library-go@cd876ac95495b21b4443029b187dec745aed3fa2
go mod tidy