Skip to content

fix: add exception for csi snapshot controller on two node #30153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eggfoobar
Copy link
Contributor

Currently, two node topologies mean that the csi snapshot controller is deployed as a single replica, during upgrades or disruption testing this goes unavailable as its moved around. Here we add a check for two node to support this exception.

Currently, two node topologies mean that the csi snapshot controller is deployed as a single replica, during upgrades or disruption testing this goes unavailable as its moved around. Here we add a check for two node to support this exception.

Signed-off-by: ehila <[email protected]>
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning August 21, 2025 19:35
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn ff46c76 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout ff46c76 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node ff46c76 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-rt-upgrade ff46c76 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn ff46c76 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 ff46c76 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-vsphere-ovn-upi ff46c76 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-single-node-serial ff46c76 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway ff46c76 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-ovn-single-node-upgrade ff46c76 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-disruptive ff46c76 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant