refactor sheerid webhook code, do not trigger on confirmed #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
reviewed
Mar 20, 2025
Member
Dantemss
left a comment
Dantemss
left a comment
There was a problem hiding this comment.
So handle_user_verification will now ignore subsequent (duplicate?) hooks, but update_user_with_verification_data and process_verification_step still change the user info and faculty status. Is that expected?
|
❌ Tests failed for Ruby 3.1. Check the workflow run for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major change is to prevent sheerid from overriding a confirmed status.
Took the liberty to try and refactor some of this code while here to make it more readable, handle error better, and increase test coverage.