VIDCS-3882: ConnectionServices Kotlin sample #548
Conversation
| @@ -0,0 +1 @@ | |||
| /build No newline at end of file | |||
There was a problem hiding this comment.
not needed, already ignored in parent gitignore.
you could remove this file
There was a problem hiding this comment.
After ignoring the /build I see a problems-report-html of the build folder. It may be better to leave it?
Basic-Video-Chat-ConnectionService-Kotlin/app/proguard-rules.pro
Outdated
Show resolved
Hide resolved
...rc/androidTest/java/com/vonage/basic_video_chat_connectionservice/ExampleInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
| <uses-permission android:name="android.permission.READ_PHONE_STATE" /> | ||
| <uses-permission android:name="android.permission.CALL_PHONE" /> | ||
| <uses-permission android:name="android.permission.MANAGE_OWN_CALLS" /> | ||
| <!--<uses-permission android:name="android.permission.BIND_TELECOM_CONNECTION_SERVICE" />--> |
| } | ||
|
|
||
| override fun onError(publisherKit: PublisherKit, opentokError: OpentokError) { | ||
| //callback?.onError("PublisherKit onError: " + opentokError.message) |
...ce-Kotlin/app/src/test/java/com/vonage/basic_video_chat_connectionservice/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
|
Fixed issues |
VZaphod
changed the title
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> | ||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_PHONE_CALL" /> | ||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" /> | ||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CAMERA" /> |
There was a problem hiding this comment.
Let;s also add Bluetooth permission
There was a problem hiding this comment.
I have just checked and with the current foreground permissions bluetooth audio devices keep connected and working in the background.
| Manifest.permission.MANAGE_OWN_CALLS | ||
| ) | ||
| else -> arrayOf( | ||
| Manifest.permission.INTERNET, |
There was a problem hiding this comment.
Bluetooth permission can also be for versions below tiramisu
There was a problem hiding this comment.
Updated permission request with customized request for each version range
|
Please add a workflow for both connection services samples https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows. It will just build the project so that we are at least aware it does not brake with future changes |
Added! |
There was a problem hiding this comment.
this file is already added in the java sample PR .github/workflows/build-basic-video-chat-connectionservice-java.yml
…n from the connection
|
@VZaphod 2.31.0 is out. We can go ahead and finish with this. |
No description provided.