VIDCS-4026 sender stats #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliobecerragomez
approved these changes
Aug 29, 2025
| * to capture information about sender stats as follows | ||
| */ | ||
| func subscriber(_ subscriber: OTSubscriberKit, videoNetworkStatsUpdated stats: OTSubscriberKitVideoNetworkStats) { | ||
| guard let senderStats = stats.senderStats else { return } |
There was a problem hiding this comment.
Nit. If there’s another iteration in this PR, it might be worth adding a comment here noting that stats could still be nil due to network issues or latency, even if the publisher’s sender stats track is enabled.
|
@aos-svg Thanks for this contribution. We cannot merge this in until the feature is our as part of 2.32.0 which should happen early next quarter (Q4). |
VZaphod
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.vonage.com/browse/VIDCS-4026
Added a sample app for users to interact with sender stats api. The environment i had to use was local dev hence the local podspec etc. ( changes werent merged yet )