Skip to content

Conversation

@amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Sep 12, 2024

Description:
Generates and passes a list of transit operator logos to map popup
Offers a shorter more efficient query for the purposes of finding operator logos

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Co-authored-by: otp-data-tools-ibi-group <[email protected]>
@amy-corson-ibigroup
Copy link
Contributor Author

Blocked by opentripplanner/otp-ui#775

@amy-corson-ibigroup amy-corson-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Sep 12, 2024
@amy-corson-ibigroup amy-corson-ibigroup self-assigned this Sep 19, 2024
@amy-corson-ibigroup amy-corson-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Oct 2, 2024
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please tidy up as indicated.

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the changes, just one style tweak.

/>
)
if (styled)
return <StyledOperatorImg alt={alt || operator.name} src={operator.logo} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surround with curly braces.

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 17598ad into dev Oct 4, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the pass-operator-logos-to-map-popup branch October 4, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants