-
Notifications
You must be signed in to change notification settings - Fork 58
Pass transit operator logos to map-popup #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: otp-data-tools-ibi-group <[email protected]>
|
Blocked by opentripplanner/otp-ui#775 |
Co-authored-by: Amy Corson <[email protected]>
…map-poup-skeletonized Skeletonize Operator Logo Loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please tidy up as indicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the changes, just one style tweak.
| /> | ||
| ) | ||
| if (styled) | ||
| return <StyledOperatorImg alt={alt || operator.name} src={operator.logo} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surround with curly braces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description:
Generates and passes a list of transit operator logos to map popup
Offers a shorter more efficient query for the purposes of finding operator logos
PR Checklist: