-
Notifications
You must be signed in to change notification settings - Fork 58
Remove most unused OTP1 fields #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
binh-dam-ibigroup
wants to merge
12
commits into
dev
Choose a base branch
from
remove-otp1-fields
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working, even with field trip! Additional testing might flag some problems with the util methods missing, but I think we are ok to merge for now! Happy to see so much of this old code gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is companion for ibi-group/otp-middleware#334 but does not require it.
Most of old OTP1, unused stuff is removed (except
agency*
,route*
, andstop*
fields that will be addressed in a subsequent PR) and some OTP2 fields that appears in mocks but aren't queried are removed too.Fields removed:
Itinerary.transitTime
Itinerary.walkLimitExceeded
Itinerary.fare
Leg.pathway
Leg.rentedCar
Leg.rentedVehicle
Leg.hailedCar
Leg.serviceDate
Leg.interstopGeometry
from/to.orig
from/to.departure
from/to.arrival
Trip.departureStopTime
Trip.arrivalStopTime
startTransitStopId
PR Checklist: