Skip to content

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Sep 8, 2025

Description

This PR is companion for ibi-group/otp-middleware#334 but does not require it.
Most of old OTP1, unused stuff is removed (except agency*, route*, and stop* fields that will be addressed in a subsequent PR) and some OTP2 fields that appears in mocks but aren't queried are removed too.

Fields removed:

  • Itinerary.transitTime
  • Itinerary.walkLimitExceeded
  • Itinerary.fare
  • Leg.pathway
  • Leg.rentedCar
  • Leg.rentedVehicle
  • Leg.hailedCar
  • Leg.serviceDate
  • Leg.interstopGeometry
  • from/to.orig
  • from/to.departure
  • from/to.arrival
  • Trip.departureStopTime
  • Trip.arrivalStopTime
  • OTP1 calltaker query param startTransitStopId

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working, even with field trip! Additional testing might flag some problems with the util methods missing, but I think we are ok to merge for now! Happy to see so much of this old code gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants