Fix user update before consents to terms #1481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Oct 10, 2025
| return !loggedInUser.hasConsentedToTerms | ||
| } | ||
|
|
||
| export function userExistsInDatabase(loggedInUser) { |
There was a problem hiding this comment.
Did you mean userDoesNotExistInDatabase or userNotInDatabase?
|
|
||
| // Determine URL and method to use. | ||
| const isCreatingUser = isNewUser(loggedInUser) | ||
| const isCreatingUser = userExistsInDatabase(loggedInUser) |
There was a problem hiding this comment.
I thought the user entry in Mongo was meant to be created when they click "Next" after accepting the terms of use. I think you uncovered a bug that results in the user being created when they set the language and before they agree to the terms. Congrats!
To fix the bug:
In lib/actions/ui.js near line 471: replace
if (loggedInUser) {
with
if (!userNotInDatabase(loggedInUser)) {
(with correct import and corrected name/meaning.
| } | ||
|
|
||
| export function userExistsInDatabase(loggedInUser) { | ||
| return !loggedInUser.id |
There was a problem hiding this comment.
loggedInUser might be null (after reloading the 'verify' page), so use the ?. optional chaining syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where if a user is on the verify email pane and they try to change the locale of the page, the page would reload and reset to the previous language. The issue was coming from a failed user update because the
isNewUsercheck was returning true (resulting in a PUT request instead of PATCH) even though the user already exists in the database at this point.PR Checklist: