Add stop code to place name in nearby view from/to picker #1482
+51
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Oct 10, 2025
| const feedId = place.gtfsId.split(':')[0] | ||
| const feed = feeds.find((f) => f.feedId === feedId) | ||
| const feedName = feed?.publisher?.name | ||
| placeForFromTo.name = `${place.name} (${feedName} ${place.code})` |
There was a problem hiding this comment.
What if there is no place.code
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
daniel-heppner-ibigroup
force-pushed
the
nearby-view-fromto-stopcode
branch
from
e96030e to
0f35ea9
Compare
|
I accidentally broke off from binh's branch but I figured it was getting merged so it wasn't a big deal. I rebased now and it looks good. |
|
So, we do have this PR which sort of has the same logic. However I'm not really sure I see a great way to reuse it here unless we extract a very simple function which I think would be overkill... I can do it if you think that would be better overall. |
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the stop code to the nearby view's from/to picker's place name. Clicking on from/to on a stop in the nearby view will now include this information in the location field.