configure.ac: remove bad macro that overwrote automake internals #10703
Conversation
In the original port to autotools, a "ts" macro was defined in m4. This meant any whole word "ts" in configure.ac or any included *.m4 file got replaced with an integer plus a newline char. Automake does this sometimes, such as in: ``` rm -f conftest.ts? ``` which was translated to: ``` rm -f conftest.20250527230813 ? ``` At the time it was used to replace, on a later line, ``` BUILD_TS=ts ``` But this was removed as "unused" in 2017. It was always the wrong way to define it and is now inert except for breaking automake. Get rid of it fully. Fixes: 597216e Signed-off-by: Eli Schwartz <[email protected]>
|
This change is licensed under the BSD license, an extremely permissive license. It's not clear to me what you need permission to relicense my contribution under a proprietary license for, given you can already do so. Aside for that, your CLA instructions tell me to mail the CLA, which seems extremely inconvenient. Especially given all I've done is delete a line, which many people would argue isn't copyrightable in the first place such that a CLA would be needed. |
@eli-schwartz Sorry for the inconvenience. According to OpenUCX organization policy, all contributors must sign a CLA stating that the contributed code is in compliance with the licensing requirements. Please feel free to follow up on this discussion with UCF Administration [email protected]. |
This is not true :) the CLA provided at https://openucx.org/wp-content/uploads/2019/05/ucx-individual-contributor-agrement.pdf contains an additional license grant unrelated to the BSD:
It is different from the BSD license, which is substantially "similar* except that it requires redistributions in source or binary form to retain the copyright notice, either in the source code or as documentation provided with the binary. The CLA exists to permit deleting the copyright notice. That is all.
Since it is possible to digitally email the administration, while it is impossible to email the CLA form, that's probably an easier solution. I'll try that. |
|
I sent the following email: Email textI have tried to contribute to the project: Unfortunately it seems I cannot do so without signing a printed form and This is burdensome to do. Mail takes time to be sent, and costs money It is not clear to me why a CLA is needed. The license is BSD -- and so The BSD3 license can only be violated by failing to include the The easiest solution here is to remove the CLA requirement. There seems You may instead be interested in: https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin https://opensource.com/article/18/3/cla-vs-dco-whats-difference |
In the original port to autotools, a "ts" macro was defined in m4. This meant any whole word "ts" in configure.ac or any included *.m4 file got replaced with an integer plus a newline char. Automake does this sometimes, such as in:
which was translated to:
At the time it was used to replace, on a later line,
But this was removed as "unused" in 2017. It was always the wrong way to define it and is now inert except for breaking automake. Get rid of it fully.
Fixes: 597216e