UCS/SYS/NETLINK: Iteratively receive netlink messages until 'done' is set #10848
+36
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleon99
reviewed
Sep 9, 2025
amastbaum
force-pushed
the
vrf_ipv6_reachability
branch
from
1a829d3 to
19620b5
Compare
gleon99
reviewed
Sep 9, 2025
yosefe
reviewed
Sep 25, 2025
src/ucs/sys/netlink.c
Outdated
|
|
||
| while ((status == UCS_INPROGRESS) && NLMSG_OK(nlh, msg_len) && | ||
| (nlh->nlmsg_type != NLMSG_DONE)) { | ||
| (!is_dump || !(*is_done_p = UCS_NETLINK_IS_MESSAGE_DONE(nlh)))) { |
There was a problem hiding this comment.
can we avoid passing int *is_done_p and is_dump to this function, and keep the logic of calling ucs_netlink_parse_msg several times in the upper function, ucs_netlink_send_request?
yosefe
reviewed
Sep 28, 2025
yosefe
reviewed
Sep 28, 2025
| rtm.rtm_table = RT_TABLE_MAIN; | ||
| ucs_netlink_send_request(NETLINK_ROUTE, RTM_GETROUTE, NLM_F_DUMP, &rtm, | ||
| sizeof(rtm), ucs_netlink_parse_rt_entry_cb, | ||
| NULL); |
There was a problem hiding this comment.
Because now we define it as RT_TABLE_UNSPEC (value 0) in order to fetch all the tables
There was a problem hiding this comment.
maybe set it explicitly to RT_TABLE_UNSPEC and comment the reason?
yosefe
reviewed
Sep 28, 2025
src/ucs/sys/netlink.c
Outdated
| int netlink_fd = -1; | ||
| int is_message_done = 0; | ||
| int is_dump = nlmsg_flags & NLM_F_DUMP; | ||
| size_t recv_msg_len = 0; |
src/ucs/sys/netlink.c
Outdated
| struct rtmsg rtm = {0}; | ||
| ucs_netlink_route_info_t info; | ||
|
|
||
| rtm.rtm_table = RT_TABLE_UNSPEC; /* fetch all the tables */ |
There was a problem hiding this comment.
maybe move it inside UCS_INIT_ONCE block? as it used to be
yosefe
approved these changes
Sep 28, 2025
amastbaum
force-pushed
the
vrf_ipv6_reachability
branch
from
5add2ce to
6d96bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Iteratively receive netlink messages until 'NLMSG_DONE' flag is set.
Why?
https://redmine.mellanox.com/issues/4607309
In some cases, when many routing rules exist (many interfaces with multiple tables), the kernel may return those rules in chunks rather than in a single response.
When
NLM_F_DUMPflag is set in the netlink request, it is actually necessary to perform multiplerecvcalls until anNLMSG_DONEmessage is received.