Fix missing result_dir parameter in evaluator constructors #2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing result_dir parameter in evaluator constructors to ensure consistent behavior with the score method when generating ground truth data.
- Add missing
result_dirparameter to_generate_datacalls in both evaluator constructors - Pass reference directory path (
os.path.join(self.gt_dir, "reference")) as the third argument - Align constructor behavior with score method data generation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/who_what_benchmark/whowhatbench/reranking_evaluator.py | Add result_dir parameter to _generate_data call in RerankingEvaluator constructor |
| tools/who_what_benchmark/whowhatbench/embeddings_evaluator.py | Add result_dir parameter to _generate_data call in EmbeddingsEvaluator constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
as-suvorov
approved these changes
Oct 13, 2025
- Fix _generate_data call in RerankingEvaluator to include result_dir parameter - Fix _generate_data call in EmbeddingsEvaluator to include result_dir parameter - Both evaluators now properly pass reference directory path when generating ground truth data - Ensures consistent behavior between constructor and score method data generation
auto-merge was automatically disabled
October 15, 2025 07:46
Head branch was pushed to by a user without write access
sswierze
force-pushed
the
sswierze_fix_reference_reranking
branch
from
a9d7574 to
776caee
Compare
|
build_jenkins |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
- Fix _generate_data call in RerankingEvaluator to include result_dir parameter - Fix _generate_data call in EmbeddingsEvaluator to include result_dir parameter - Both evaluators now properly pass reference directory path when generating ground truth data - Ensures consistent behavior between constructor and score method data generation ## Description <!-- Please include a summary of the change. Also include relevant motivation and context. --> <!--- Jira ticket number (e.g., 123). Delete if there's no ticket. Don't include full link or project name. --> Ticket: <!-- Remove if not applicable --> Fixes #(issue) ## Checklist: - [ ] Tests have been updated or added to cover the new code <!--- If the change isn't maintenance related, update the tests at https://github.com/openvinotoolkit/openvino.genai/tree/master/tests or explain in the description why the tests don't need an update. --> - [ ] This patch fully addresses the ticket. <!--- If follow-up pull requests are needed, specify in description. --> - [ ] I have made corresponding changes to the documentation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket:
Fixes #(issue)
Checklist: