-
Notifications
You must be signed in to change notification settings - Fork 532
Add unsecure credential storage option #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add unsecure credential storage option #3824
Conversation
Signed-off-by: PatStLouis <[email protected]>
|
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
…-cloudagent-python into store-unsecure-credentials
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only mark ready / tag for review when PR tests are passing. Because it gives a GitHub notification for each new commit. And if I see tests aren't passing, then I know it's not ready to merge / not ready for review.
FYI, if you didn't realize. We fail the test run for most warnings. There is a few of them that need to be fixed. |
This adds an option to store a W3C VC without verifying it's proof on the
/vc/credentials/store
endpoint.This option will default to true, and can be turned off (unsecured) for experimenting with unsupported cryptosuites and/or did methods.
The DataModel will still be validated, this only affects the proof verification step.