Skip to content

Fix a realpath failure when resolving course symlinks. (hotfix of #2793) #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Fix a realpath failure when resolving course symlinks. (hotfix of #2793) #2794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/WeBWorK/Utils/CourseDirectoryIntegrityCheck.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ sub checkCourseLinks {
# All links should actually be links, and should have the correct target. Note that the link target may also be
# a link, and so the realpath of the configured link target and realpath of the course link path must be
# compared to check that the link target is correct.
my $good = -l $path && path($path)->realpath eq path($target)->realpath;
my $good = -l $path && (eval { path($path)->realpath } // '') eq path($target)->realpath;

$links_ok = 0 if !$good;
push @results, [ $link, $target, $path, $good ];
Expand Down Expand Up @@ -213,7 +213,7 @@ sub updateCourseLinks {
my $targetIsCorrect = 0;

if (-l $path) {
$targetIsCorrect = path($path)->realpath eq path($target)->realpath;
$targetIsCorrect = (eval { path($path)->realpath } // '') eq path($target)->realpath;
next if $targetIsCorrect;
}

Expand Down