-
Notifications
You must be signed in to change notification settings - Fork 225
feat: CI for java 25 #2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: CI for java 25 #2947
Conversation
Signed-off-by: Attila Mészáros <[email protected]>
8162728
to
64ae8ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should be changed as this isn't an actual support of Java 25, just running CI on Java 25.
Also, at this point, I don't think that there's a Temurin Java 25 distribution available. |
It is not the same thing? So basically the SDK works with java 25 |
No, will wait for that before this is merged. |
Well, not quite. We're just checking that it works with Java 25, not the same thing as actually doing something to support it. For that matter, have you actually checked that the SDK builds on Java 25? |
What I mean is this what we do for any java >17. But changed the title of the PR |
For info, I've tried building with Java 25 and it appears the spotless plugin doesn't work on Java 25. |
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
fixed |
Cool! We should still wait for the Temurin releases. |
Signed-off-by: Attila Mészáros [email protected]