Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2025

Signed-off-by: Attila Mészáros [email protected]

@openshift-ci openshift-ci bot requested review from metacosm and xstefank September 17, 2025 08:09
Signed-off-by: Attila Mészáros <[email protected]>
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be changed as this isn't an actual support of Java 25, just running CI on Java 25.

@metacosm
Copy link
Collaborator

Also, at this point, I don't think that there's a Temurin Java 25 distribution available.

@csviri
Copy link
Collaborator Author

csviri commented Sep 17, 2025

The commit message should be changed as this isn't an actual support of Java 25, just running CI on Java 25.

It is not the same thing? So basically the SDK works with java 25

@csviri
Copy link
Collaborator Author

csviri commented Sep 17, 2025

Also, at this point, I don't think that there's a Temurin Java 25 distribution available.

No, will wait for that before this is merged.

@csviri csviri changed the title feat: java 25 support feat: CI for java 25 Sep 17, 2025
@metacosm
Copy link
Collaborator

The commit message should be changed as this isn't an actual support of Java 25, just running CI on Java 25.

It is not the same thing? So basically the SDK works with java 25

Well, not quite. We're just checking that it works with Java 25, not the same thing as actually doing something to support it. For that matter, have you actually checked that the SDK builds on Java 25?

@csviri
Copy link
Collaborator Author

csviri commented Sep 17, 2025

Well, not quite. We're just checking that it works with Java 25, not the same thing as actually doing something to support it.

What I mean is this what we do for any java >17. But changed the title of the PR

@metacosm
Copy link
Collaborator

metacosm commented Sep 17, 2025

For info, I've tried building with Java 25 and it appears the spotless plugin doesn't work on Java 25.

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
Copy link
Collaborator Author

csviri commented Sep 17, 2025

fixed

@metacosm
Copy link
Collaborator

Cool! We should still wait for the Temurin releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants