Skip to content

[WIP] feat: experimental utility methods to add finalizer #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

[WIP] feat: experimental utility methods to add finalizer #2948

wants to merge 2 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2025 •
edited
Loading

Improved way to add finalizers:

  • Gets the resource on retry from informer cache not a separate API call, so reduces the number of Kubernetes API calls
  • Caches the updated resource, making sure it is available for next reconiliation

TODO:

  • check if finalizer already there when retrying
  • discuss: have this as default way of adding finalizers (behind feature flag?)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@csviri csviri changed the base branch from main to next September 17, 2025 11:27
@csviri csviri changed the title new finalizer add feat: experimental utility methods to add finalizer Sep 17, 2025
@csviri csviri changed the title feat: experimental utility methods to add finalizer [WIP] feat: experimental utility methods to add finalizer Sep 17, 2025
@csviri
format
1149282 
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@csviri