Missing parent entity prevents card acknowledgment (#9235)

[vlo-rte]

• In release notes :
  • In chapter : Bugs
  • Text : Missing parent entity prevents card acknowledgment #9235 : Missing parent entity prevents card acknowledgment

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates AcknowledgeUtils.ts to add defensive null-checking when retrieving entities by ID. Instead of accessing EntitiesService.getEntity(entityId).parents directly, the code now assigns the fetched entity to a local variable, verifies it exists, logs a warning via LoggerService if missing, and only then accesses and collects parent IDs. Behavior for found entities and the existing filtering logic remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file change with a consistent defensive pattern
• Adds null-checks and warning logs without complex new logic
• Verify logging invocation and no behavioral changes for existing entities
• Files to inspect:
  • frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: fixing a bug where missing parent entities prevent card acknowledgment.
Description check	✅ Passed	The description matches the template structure with all required sections populated: release notes chapter (Bugs) and descriptive text with issue reference (#9235).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch FE-9235-MissingParentEntityPreventsCardAcknowledgment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 709bbf5 and 487ebfc.

📒 Files selected for processing (1)

• frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build
• GitHub Check: build

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts (1)

23-34: Excellent defensive fix for missing entities.

The null-check prevents the runtime error described in the PR title. The code now gracefully handles cases where an entity ID exists in the user's entity list but the entity itself is not found in the cache, allowing acknowledgment to proceed for other valid entities.

Optionally, consider making the warning message more contextual for debugging:

 if (!entity) {
-    logger.warn(`Entity with id ${entityId} not found`);
+    logger.warn(`Entity with id ${entityId} not found when determining entities allowed to acknowledge`);
 } else {

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 164f486 and 121df7b.

📒 Files selected for processing (1)

• frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts (1)

frontend/src/app/services/entities/EntitiesService.ts (1)

• EntitiesService (21-265)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build
• GitHub Check: build

🔇 Additional comments (1)

frontend/src/app/services/acknowlegment/AcknowledgeUtils.ts (1)

12-12: LGTM: Logger import added correctly.

The LoggerService import is necessary for the new defensive logging and follows the existing codebase pattern.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud