Updated to most recent cucumber, fixed npm audit vulnerabilities. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @natcarey; we've just run into the same issue. Did you make any more progress? If not, we'll pick it up from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft, I've got some bits left to do.
I tried using the project and found it unusable on an M1 Mac, the cucumberjs version was quite out of date and there were various vulnerabilities.
I have updated dependencies (
npm audit fix) and moved over to@cucumber/cucumber. This required a significant change to the integration. I have introduced asetupfunction which does this wiring as I couldn't see a way of autowiring it when someone uses the World.If this is a change you'd like to bring in I'll keep working on the teardown, if not I'll use puppeteer and cucumberjs with the knowledge I've aquired while preparing this PR.