Alternative solution for julian (ch06-03) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another strike against my solution: 7-4 isn't really compatible with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the current approach to
julian/5to be a bit difficult to explain and understand.This feels much more natural to me (but, admittedly, I'm only a year into playing with Erlang, so take that with a grain of salt).
It reflects the style advocated by @gar1t in his blog post Solving Embarrassingly Obvious Problems In Erlang, which doesn't fit all that well with other examples given.
Note: there's also a bug fix buried in here: the last
integerin the argument list in the spec forjulian/5should beinteger()for dialyzer to work properly.