src: Update Registration step based on mocks (HMS-9409)

[regexowl]

This moves registration options outside of the "Show additional connection options" expandable, making them always visible.

It also adds back the step description and updates the organization ID clipboard copy based on recent mocks.

The "Register now" part of Registration step should reflect final mocks.

Related to HMS-8823

JIRA: HMS-9409

[regexowl]

Draft waiting for copy update.

[github-actions]

This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days.

[codecov]

Codecov Report

❌ Patch coverage is 74.26471% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.58%. Comparing base (a34952a) to head (b0c10af).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...gistration/components/ActivationKeyInformation.tsx	0.00%	33 Missing ⚠️
...ard/steps/Registration/components/Registration.tsx	95.45%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   83.99%   83.58%   -0.42%     
==========================================
  Files         214      214              
  Lines       24902    24827      -75     
  Branches     2641     2623      -18     
==========================================
- Hits        20917    20752     -165     
- Misses       3957     4047      +90     
  Partials       28       28              

Files with missing lines	Coverage Δ
...eps/Registration/components/ActivationKeysList.tsx	77.51% <100.00%> (+1.52%)	⬆️
...nts/CreateImageWizard/steps/Registration/index.tsx	100.00% <100.00%> (ø)
...teImageWizard/steps/Review/ReviewStepTextLists.tsx	90.67% <100.00%> (-0.04%)	⬇️
...t/Components/CreateImageWizard/wizardTestUtils.tsx	94.88% <100.00%> (ø)
...ard/steps/Registration/components/Registration.tsx	93.18% <95.45%> (-3.25%)	⬇️
...gistration/components/ActivationKeyInformation.tsx	6.25% <0.00%> (-80.93%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34952a...b0c10af. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[regexowl]

I've updated this to reflect the final mocks. "Register now" option should be fully up to date, I'll update "register later" in #3423, double check the Satellite registration and this step should be done I think...

[regexowl]

/retest

[regexowl]

/jira-epic HMS-9385

[regexowl]

/retest

[regexowl]

Also happy to squash the commits, wanted to split the original work from the final revamp points.

[regexowl]

The test failure is not relevant to this PR and should be fixed in #3669

[kingsleyzissou]

This looks great,

I wonder if we should maybe hide the activation keys Details button if no activation key is available or selected:

This could be done in a follow up though

[regexowl]

I wonder if we should maybe hide the activation keys Details button if no activation key is available or selected:

Great point! I've added a prop to disable the button when there's no activation key selected. I've also squashed the commits so the PR is a bit neater.

[regexowl]

I wonder if we should maybe hide the activation keys Details button if no activation key is available or selected:

I swear my reading comprehension isn't usually this bad - the button is now disabled with no activation key, I could also hide the button completely.

I usually lean towards enabling/disabling interactive parts of the form so they don't "jump" at the user out of nowhere, but that's just subjective feeling so happy to do whatever works better 😅

[kingsleyzissou]

I usually lean towards enabling/disabling interactive parts of the form so they don't "jump" at the user out of nowhere, but that's just subjective feeling so happy to do whatever works better 😅

No disabling it is probably better for these exact reasons. Also easier to test!