cockpit: use upstream cockpit types #3640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors some of the cockpit api file end extracts all the helper functions to their own file. This just makes the file more manageable to work with.
kingsleyzissou
commented
Sep 12, 2025
| // types. We have stubbed those functions out for the | ||
| // as this is the tsconfig file for the service. | ||
| "./src/test/mocks/*" | ||
| "./pkg/lib/*" |
There was a problem hiding this comment.
This is up for discussion, we might have to keep a copy of the cockpit.d.ts file in the repo and make sure it matches the commit hash in the makefile.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
- Coverage 82.48% 76.76% -5.73%
==========================================
Files 214 228 +14
Lines 24993 26857 +1864
Branches 2589 2603 +14
==========================================
Hits 20616 20616
- Misses 4350 6200 +1850
- Partials 27 41 +14
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Since we've made our typescript checks stricter, we can rely on the cockpit types from upstream. This will prevent drift between the types. The one downside to this is that we may have to keep the some of the cockpit lib files and make sure they match the commit hash in the makefile.
kingsleyzissou
force-pushed
the
cockpit-types
branch
from
61014a3 to
1ca0a10
Compare
|
We can re-open this later down the line if we need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've made our typescript checks stricter, we can rely on the cockpit
types from upstream. This will prevent drift between the types. The one downside
to this is that we may have to keep the cockpit
pkg/libdirectory in the repository.