Add support for free-threading wheels #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imciner2
force-pushed
the
im/freethread
branch
from
88c9c6e to
ffcda8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the QDLDL wheels to be built with the free-threading support (aka. no-GIL).
I think all we need to do is add the
py::mod_gil_not_used()to our module, and that will also disable all our other calls releasing/acquiring the GIL.I am basing the cibuildwheel change off of the documentation here: https://py-free-threading.github.io/ci/#building-free-threaded-wheels-with-cibuildwheel