-
Notifications
You must be signed in to change notification settings - Fork 6
Added the Documentation for all HTML, js files and README #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merge from dev_devayani's branch to dev_luis.
… layout of the page in .html language. Included images to enhance clarity.
Documented all .html files in /web/ using Markdown (.md) files.
Sprint 3 Pull Request
Added docs
Updated readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Docusaurus documentation website to the repository. The main change involves updating the version constraint for @docusaurus/preset-classic from an exact version to a caret range and marking several peer dependencies in the lock file.
Key Changes
- Updated
@docusaurus/preset-classicversion constraint from3.8.1to^3.8.1in bothdocs/package.jsonanddocs/package-lock.json - Added
peer: trueflags to various dependencies in the package-lock.json - Added a complete Docusaurus website scaffold in
docs/my-website/with version 3.9.2
Reviewed Changes
Copilot reviewed 37 out of 75 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/package.json | Changed @docusaurus/preset-classic from exact version to caret range |
| docs/package-lock.json | Added peer dependency flags and updated dependency metadata |
| docs/my-website/package.json | Added new Docusaurus website with version 3.9.2 dependencies |
| docs/my-website/* | Added complete Docusaurus scaffold including config, pages, components, and static assets |
Files not reviewed (1)
- docs/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@docusaurus/core": "3.8.1", | ||
| "@docusaurus/preset-classic": "3.8.1", | ||
| "@docusaurus/preset-classic": "^3.8.1", |
Copilot
AI
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent version pinning strategy: @docusaurus/core uses an exact version (3.8.1) while @docusaurus/preset-classic uses a caret range (^3.8.1). These packages should typically be kept at the same version to avoid compatibility issues. Consider using the same versioning strategy for both packages, preferably exact versions for better reproducibility.
| "@docusaurus/core": "3.9.2", | ||
| "@docusaurus/preset-classic": "3.9.2", |
Copilot
AI
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch between parent and nested package.json files: The parent docs/package.json uses Docusaurus 3.8.1 while docs/my-website/package.json uses 3.9.2. This creates confusion about which version is actually being used and may lead to dependency conflicts. Consider aligning these versions across both files.
thehabes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of work here, a lot of files so I may not have looked as closely at everything as you might like.
The file structure is confusing. You have a /docs directory with a /docs directory in it. It seems like the entire /docs/my-website directory should be removed maybe?
I asked Claude about it and got these notes, which I think should be addressed as part of this PR.
Spelling & Grammar Errors:
-
tools.js(line 86)- Error: "higlighting"
- Should be: "highlighting"
- Comment reads:
* Render tools, higlighting recently used ones.
-
CONTRIBUTING.md(line 24)- Error: "seperate" → should be "separate"
- Error: "requred" → should be "required"
- Error: "extention" → should be "extension"
- Sentence: "The code base is in HTML, CSS, JS so there is no seperate software installation is requred. Just run the code it will open and renders in your default browser. Use the live server extention if needed."
- Grammar: "installation is requred" is awkward; should be "installation required"
-
JSON_Documentation_README.md(line 20)- Error: "more savvier" is grammatically incorrect
- Should be: "savvier" or "more savvy"
- Sentence: "JSON-LD is like a more savvier JSON."
-
about.html(line 45)- Missing quotes: "jobTitle": Software Engineer should be "jobTitle": "Software Engineer"
- This is inconsistent with line 58 which correctly has quotes
File structure concerns
The structure makes sense except:
- my-website should be deleted (it's the default Docusaurus template)
- Docusaurus is being used for developer documentation, which is fine, but it should be properly configured or removed if not actually deployed
Docusaurus Issues
- It's not deployed or linked from the main web application
- The main app in
webis standalone HTML/CSS/JS - Docusaurus appears to be for internal documentation only (explaining the HTML structure)
- The
my-websitesubfolder is completely redundant and should be removed
- Docusaurus configuration problems in
dpcusaurus.config.js- Still references Facebook/Docusaurus placeholder value
organizationName: 'facebook' (line 29) → should be 'oss-slu'projectName: (line 30) → should be 'rerum-playground'editUrl: points to Facebook's repo (lines 51-52, 62-63)- GitHub links in navbar and footer point to 'https://github.com/facebook/docusaurus'
- Footer copyright says "My Project, Inc." instead of the actual project name
- Still references Facebook/Docusaurus placeholder value
- Duplicate/Redundant Structure
- There's a
my-websitefolder that appears to be a duplicate Docusaurus setup - This creates confusion - there are TWO complete Docusaurus sites
docs(the main one being customized)my-website(appears to be the default template, unused)
- There's a
README issues
- Set up instructions saying to right click on
index.htmlare pointing to the root. There is noindex.htmlat the root.
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
| node-version: '22' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTS is node 24 now!
No description provided.