Skip to content

Conversation

@Devayani1612
Copy link
Collaborator

No description provided.

@Devayani1612 Devayani1612 changed the title Added the Documentation for all HTML and js files. Added the Documentation for all HTML, js files and README Oct 30, 2025
@thehabes thehabes requested a review from Copilot November 1, 2025 20:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Docusaurus documentation website to the repository. The main change involves updating the version constraint for @docusaurus/preset-classic from an exact version to a caret range and marking several peer dependencies in the lock file.

Key Changes

  • Updated @docusaurus/preset-classic version constraint from 3.8.1 to ^3.8.1 in both docs/package.json and docs/package-lock.json
  • Added peer: true flags to various dependencies in the package-lock.json
  • Added a complete Docusaurus website scaffold in docs/my-website/ with version 3.9.2

Reviewed Changes

Copilot reviewed 37 out of 75 changed files in this pull request and generated 2 comments.

File Description
docs/package.json Changed @docusaurus/preset-classic from exact version to caret range
docs/package-lock.json Added peer dependency flags and updated dependency metadata
docs/my-website/package.json Added new Docusaurus website with version 3.9.2 dependencies
docs/my-website/* Added complete Docusaurus scaffold including config, pages, components, and static assets
Files not reviewed (1)
  • docs/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 17 to +18
"@docusaurus/core": "3.8.1",
"@docusaurus/preset-classic": "3.8.1",
"@docusaurus/preset-classic": "^3.8.1",
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent version pinning strategy: @docusaurus/core uses an exact version (3.8.1) while @docusaurus/preset-classic uses a caret range (^3.8.1). These packages should typically be kept at the same version to avoid compatibility issues. Consider using the same versioning strategy for both packages, preferably exact versions for better reproducibility.

Copilot uses AI. Check for mistakes.
Comment on lines +17 to +18
"@docusaurus/core": "3.9.2",
"@docusaurus/preset-classic": "3.9.2",
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch between parent and nested package.json files: The parent docs/package.json uses Docusaurus 3.8.1 while docs/my-website/package.json uses 3.9.2. This creates confusion about which version is actually being used and may lead to dependency conflicts. Consider aligning these versions across both files.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@thehabes thehabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of work here, a lot of files so I may not have looked as closely at everything as you might like.

The file structure is confusing. You have a /docs directory with a /docs directory in it. It seems like the entire /docs/my-website directory should be removed maybe?

I asked Claude about it and got these notes, which I think should be addressed as part of this PR.

Spelling & Grammar Errors:

  1. tools.js (line 86)

    • Error: "higlighting"
    • Should be: "highlighting"
    • Comment reads: * Render tools, higlighting recently used ones.
  2. CONTRIBUTING.md (line 24)

    • Error: "seperate" → should be "separate"
    • Error: "requred" → should be "required"
    • Error: "extention" → should be "extension"
    • Sentence: "The code base is in HTML, CSS, JS so there is no seperate software installation is requred. Just run the code it will open and renders in your default browser. Use the live server extention if needed."
    • Grammar: "installation is requred" is awkward; should be "installation required"
  3. JSON_Documentation_README.md (line 20)

    • Error: "more savvier" is grammatically incorrect
    • Should be: "savvier" or "more savvy"
    • Sentence: "JSON-LD is like a more savvier JSON."
  4. about.html (line 45)

    • Missing quotes: "jobTitle": Software Engineer should be "jobTitle": "Software Engineer"
    • This is inconsistent with line 58 which correctly has quotes

File structure concerns

The structure makes sense except:

  1. my-website should be deleted (it's the default Docusaurus template)
  2. Docusaurus is being used for developer documentation, which is fine, but it should be properly configured or removed if not actually deployed

Docusaurus Issues

  • It's not deployed or linked from the main web application
  • The main app in web is standalone HTML/CSS/JS
  • Docusaurus appears to be for internal documentation only (explaining the HTML structure)
  • The my-website subfolder is completely redundant and should be removed
  1. Docusaurus configuration problems in dpcusaurus.config.js
    • Still references Facebook/Docusaurus placeholder value
      • organizationName: 'facebook' (line 29) → should be 'oss-slu'
      • projectName: (line 30) → should be 'rerum-playground'
      • editUrl: points to Facebook's repo (lines 51-52, 62-63)
      • GitHub links in navbar and footer point to 'https://github.com/facebook/docusaurus'
      • Footer copyright says "My Project, Inc." instead of the actual project name
  2. Duplicate/Redundant Structure
    • There's a my-website folder that appears to be a duplicate Docusaurus setup
    • This creates confusion - there are TWO complete Docusaurus sites
      • docs (the main one being customized)
      • my-website (appears to be the default template, unused)

README issues

  1. Set up instructions saying to right click on index.html are pointing to the root. There is no index.html at the root.

uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '22'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTS is node 24 now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants