Skip to content

fix: Set a default artifact location URI value #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

fix: Set a default artifact location URI value #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3ccd35
fix: Set a default artifact location URI value
eddie-knight Nov 13, 2025
d8d5457
fix: improve table tests
eddie-knight Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions layer4/evaluation_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"github.com/ossf/gemara/layer2"
)

var emptyArtifactURIMessage = "no file associated with this alert"

// ToSARIF converts the evaluation results into a SARIF document (v2.1.0).
// Each AssessmentLog is emitted as a SARIF result. The rule id is derived from
// the control id and requirement id.
Expand Down Expand Up @@ -104,13 +106,13 @@ func (e EvaluationLog) ToSARIF(artifactURI string, catalog *layer2.Catalog) ([]b
}

var physicalLocation *PhysicalLocation
if artifactURI != "" {
physicalLocation = &PhysicalLocation{
ArtifactLocation: ArtifactLocation{
URI: artifactURI,
},
// Region left nil - no line/column data available
}
if artifactURI == "" {
artifactURI = emptyArtifactURIMessage
}
physicalLocation = &PhysicalLocation{
ArtifactLocation: ArtifactLocation{
URI: artifactURI,
},
}

// Use the last AssessmentStep for LogicalLocation (the location is for the entire evaluation)
Expand Down
Loading
Loading