Skip to content

Improve package manager UX #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve package manager UX #1710

wants to merge 4 commits into from

Conversation

samamou
Copy link
Contributor

@samamou samamou commented Feb 6, 2025

closes issue #1701

@samamou samamou linked an issue Feb 6, 2025 that may be closed by this pull request
Improve package manager UX #1701
Open
4 tasks
@samamou samamou changed the title Add hardcoded categories Improve package manager UX Feb 6, 2025
@samamou samamou mentioned this pull request Feb 6, 2025
Open
7 tasks
samamou
samamou commented Feb 7, 2025
View reviewed changes
src/plugins/score-plugin-packagemanager/PackageManager/View.cpp
return;
QNetworkRequest rqst{
QUrl("https://raw.githubusercontent.com/ossia/score-addons/master/addons.json")};
QUrl("https://raw.githubusercontent.com/ossia/score-addons/refs/heads/"
Copy link
Contributor Author

@samamou samamou Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO: Change back when this branch is merged with main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still pointing to my branch for testing purposes, should point to master when merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you are ready to merge add a last commit that does this change!

samamou
samamou commented Feb 11, 2025
View reviewed changes
src/plugins/score-plugin-packagemanager/PackageManager/Presenter.cpp Outdated

ps_view.remoteView()->setSelectionModel(&ps_model.remoteSelection);

// ps_view.remoteView()->setSelectionModel(&ps_model.remoteSelection);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to re-enable this for the install button to work

@samamou samamou marked this pull request as ready for review February 13, 2025 16:08
@samamou
Copy link
Contributor Author

samamou commented Feb 27, 2025 •
edited
Loading

Can we please check why the checks are failing so we can merge soon? @jcelerier
image

@jcelerier jcelerier force-pushed the 1701-improve-package-manager-ux branch from abedc99 to c2c00cf Compare March 22, 2025 14:42
@jcelerier
Copy link
Member

I just rebased on current master which has fully green CI so that we can see if there's any failure related to this patch specifically :)

@jcelerier
Copy link
Member

CI is green in all the places that matter :)

@jcelerier
Copy link
Member

what else do we need here?

@jcelerier
Copy link
Member

aaaaa never git merge :`)

$ git checkout master
$ git pull
$ git checkout -
$ git rebase master
<it will likely skip the last commit since it's redundant now>
$ git push --force

@samamou samamou force-pushed the 1701-improve-package-manager-ux branch from 687c9a0 to 8ce4374 Compare April 3, 2025 06:40
jcelerier
jcelerier approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@jcelerier jcelerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! what is remaining?

src/plugins/score-plugin-packagemanager/PackageManager/View.cpp
m_progress->setValue(((bytesReceived / 1024.) / (bytesTotal / 1024.)) * 100);
}

void PluginSettingsView::updateCategoryComboBox(int tabIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looking good!

@samamou
Copy link
Contributor Author

samamou commented Apr 4, 2025

nothing! can we merge? :) @jcelerier

@jcelerier
Copy link
Member

gonna test-drive it locally and then yes ! :)

@jcelerier
Copy link
Member

a
hmm when I set the combobox, I don't see any change, what is supposed to happen ?

@samamou
Copy link
Contributor Author

samamou commented Apr 5, 2025

Ypu don't see any change because it wasn't implemented 🙈 kept it on pause.....

After the last commit, this should be the behavior. can you please test one last time? @jcelerier

Screen.Recording.2025-04-05.at.6.48.57.PM.mov

@samamou samamou requested a review from jcelerier April 5, 2025 22:55
jcelerier
jcelerier approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@jcelerier jcelerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooops I had done the review but forgot to submit it

src/plugins/score-plugin-packagemanager/PackageManager/View.cpp
return;
QNetworkRequest rqst{
QUrl("https://raw.githubusercontent.com/ossia/score-addons/master/addons.json")};
QUrl("https://raw.githubusercontent.com/ossia/score-addons/refs/heads/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you are ready to merge add a last commit that does this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcelerier jcelerier jcelerier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve package manager UX

2 participants

@samamou @jcelerier