Sqlutils cleanups #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unconditional Close() will cause a nil-pointer deference if err != nil, since rows will be nil if there was an error.
gofmt -w -r 'errors.New(fmt.Sprintf(a,b)) -> fmt.Errorf(a,b)' sqlutils.go
|
https://github.com/outbrain/golib/blob/master/sqlutils%2Fsqlutils.go#L74 IMHO: a check for .Valid is missing: cell.Valid |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small tweaks for sqlutils.
Only the defer Close() commit is an actual bug fix. The extra error checks are "nice to have" and reduce errors later in Orchestrator. The rest are style fixes.
/cc @rbastic @sjmudd